Skip to content

Add SDG background color classes#4698

Merged
t-will-gillis merged 1 commit intogh-pagesfrom
unknown repository
May 21, 2023
Merged

Add SDG background color classes#4698
t-will-gillis merged 1 commit intogh-pagesfrom
unknown repository

Conversation

@jenny-alexander
Copy link
Member

Fixes #4344

What changes did you make and why did you make them ?

WHAT CHANGES:

  • In the _sass/elements, create a new file: _background-sdg-colors.scss
  • In the _background-sdg-colors.scss file, I added the following:
.background-color-sdg2 { background-color: $color-sdg2; }
.background-color-sdg3 { background-color: $color-sdg3; }
.background-color-sdg4 { background-color: $color-sdg4; }
.background-color-sdg5 { background-color: $color-sdg5; }
.background-color-sdg8 { background-color: $color-sdg8; }
.background-color-sdg9 { background-color: $color-sdg9; }
.background-color-sdg10 { background-color: $color-sdg10; }
.background-color-sdg11 { background-color: $color-sdg11; }
.background-color-sdg13 { background-color: $color-sdg13; }
.background-color-sdg16 { background-color: $color-sdg16; }
.background-color-sdg17 { background-color: $color-sdg17; }

-In the _sass/main.scss, under the Elements section, add the following import statement under the Elements section
@import 'elements/background-sdg-colors';

WHY WERE CHANGES MADE:
These changes were made so we can use these classes with their corresponding, matching SDG icons.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Only scss file was created and imported. Code changes made had no impact on look of website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jenny-alexander-add-sdg-background-color-classes-4344 gh-pages
git pull https://github.com/jenny-alexander/website.git add-sdg-background-color-classes-4344

@github-actions github-actions bot added role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels May 19, 2023
@one2code one2code self-assigned this May 20, 2023
@one2code
Copy link
Member

ETA: 5/21/23

@one2code one2code self-requested a review May 21, 2023 06:55
@one2code one2code removed their assignment May 21, 2023
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name, contents, and file path are correct, and the import file in _sass/main.scss is named and placed under the Elements header, as identified in the action items for this issue.

Everything looks good. Congratulations on a job well done!

@t-will-gillis t-will-gillis self-requested a review May 21, 2023 16:11
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jenny-alexander - good work! Your branches look good, you are linked to the issue, your description tells what you did and why, and you noted that there are no visual changes to the website (until later issues reference these colors). Thanks for taking care of this-

@t-will-gillis t-will-gillis merged commit 2a7ccc0 into hackforla:gh-pages May 21, 2023
@jenny-alexander jenny-alexander deleted the add-sdg-background-color-classes-4344 branch May 21, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SDG background color classes: 2-5, 8-11, 13, 16, 17

3 participants