Add SDG background color classes#4698
Add SDG background color classes#4698t-will-gillis merged 1 commit intogh-pagesfrom unknown repository
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 5/21/23 |
one2code
left a comment
There was a problem hiding this comment.
The file name, contents, and file path are correct, and the import file in _sass/main.scss is named and placed under the Elements header, as identified in the action items for this issue.
Everything looks good. Congratulations on a job well done!
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @jenny-alexander - good work! Your branches look good, you are linked to the issue, your description tells what you did and why, and you noted that there are no visual changes to the website (until later issues reference these colors). Thanks for taking care of this-
Fixes #4344
What changes did you make and why did you make them ?
WHAT CHANGES:
-In the _sass/main.scss, under the Elements section, add the following import statement under the Elements section
@import 'elements/background-sdg-colors';WHY WERE CHANGES MADE:
These changes were made so we can use these classes with their corresponding, matching SDG icons.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Only scss file was created and imported. Code changes made had no impact on look of website.