Update labels: blank-issue-template(role,size,feature,complexity as missing)#4702
Update labels: blank-issue-template(role,size,feature,complexity as missing)#4702blulady merged 4 commits intohackforla:gh-pagesfrom kiwookim:update-label-blank-4503
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETA: 2 PM 5/20/23 |
matthewmpan
left a comment
matthewmpan
left a comment
There was a problem hiding this comment.
Hi @kiwookim Your branches are set up correctly and your feature branch is appropriately named. I would recommend giving your pull request a more descriptive title that highlights your changes.
You correctly linked the issue and checked off all of the action items listed. However, there are two places in issue #4503 to replace existing [placeholders] with a link to the issue template in your repo. The first section is in the issue section Link for Reviewers and the second section is in your comment in checkbox 9. The link to your issue template should look something like this: https://github.com/kiwookim/website/issues/new?assignees=&labels=role+missing%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=blank-issue-template.md&title=
Lastly, revert your last commit aa81ad3. Line 18 of .github/ISSUE_TEMPLATE/blank-issue-template.md is meant to serve as part of the issue template for new issues, letting issue creators know where to add additional Resources/Instructions.
|
Availability: Tuesday, Thursday and Sunday from 7am to 5pm |
93Belen
left a comment
93Belen
left a comment
There was a problem hiding this comment.
Hey, great job on changing the labels! You did the pull request from the correct branch and linked the issue correctly. Nice work!
I noticed that you added the correct labels, but you also included some code on lines 19 and 20 that wasn't mentioned in the issue.
Remember to include the link to the test repository in the placeholders so we can review the visual changes.
Also, I would mention what labels you added in the description and update the title for a more descriptive one.
Keep up the good work! Let me know if you have any questions or need help.
kiwookim
changed the title
|
Hi, Matthew and Belen! Thank you for your reviews. I changed the title of the PR, added the URL, and removed unnecessary comments and code in the readme file. Please let me know if there is anything else. Thank you. |
|
Review ETA: EOD 5/24/23 |
|
Availability: Thursday and Sunday from 6am to 6pm |
roslynwythe
left a comment
roslynwythe
left a comment
There was a problem hiding this comment.
Hi @kiwookim Thank you for your work on this issue, and in particular for following the test procedure and checking off those items. Please update the section of the PR that says "[REPLACE THIS TEXT WITH URL OF THE ISSUE TEMPLATE ON THE TEST REPO]" with the actual URL, for the convenience of the other reviewers. I did follow the URL to the template and it looks fine to me. Everything else looks good as well: the branches are properly formed and the code change is clean. So I'll approve this as soon as the URL is posted in the PR.
Thank you Roslyn! |
There was a problem hiding this comment.
Hi @kiwookim Thanks for making the requested changes to the PR name, lines 18-20, and adding the reviewer link. I was able to confirm the changes in the issue template and everything looks good. Great work!
roslynwythe
left a comment
roslynwythe
left a comment
There was a problem hiding this comment.
Hi @kiwookim thank you for making the request changes.
93Belen
left a comment
93Belen
left a comment
There was a problem hiding this comment.
Hi! Thanks for adding the link! nice job addressing the requested changes!
5 participants
Fixes #4503
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website