Updated emergent-request.md labels -- #4502#4730
Updated emergent-request.md labels -- #4502#4730t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
LOSjr4
left a comment
There was a problem hiding this comment.
Good job following the steps of this issue @LRenDO! Even I wasn't sure how to verify the changes at first, and I've been here a few months.
I checked the link Ren left and verified the correct additions were made. Ren also wrote up a nice description of what was done including screenshots. I also noticed the additional checklist Ren followed in the comment section of the original issue as instructed.
Thank you for the good work Ren!
|
Availability: 5/26-5/27 1pm-4pm |
|
The pull request is done in the correct branch and you linked to the issue. The emergent request markdown file has been updated correctly. Great job! |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @LRenDO - Great job! everything looks good: your branches, you linked the issue, your description tells the whats and whys, you included visuals, and your code changes are clean and concise, and when I test the code it adds the correct labels to the new issue.
Thanks!
|
@LOSjr4 @ldietz08 @t-will-gillis Thanks for the specific feedback y'all! |
Fixes #4502
What changes did you make and why did you make them ?
labels: 'size: 0.25pt'tolabels: ['size: 0.25pt', 'role missing', 'Feature Missing', 'Complexity: Missing']in
.github/ISSUE_TEMPLATE/emergent-request.mdScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: Updated Emergent Issue Template
For PM, Merge Team, or Tech Lead