Skip to content

Updated emergent-request.md labels -- #4502#4730

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
LRenDO:update-emergent-request-labels
May 28, 2023
Merged

Updated emergent-request.md labels -- #4502#4730
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
LRenDO:update-emergent-request-labels

Conversation

@LRenDO
Copy link
Member

@LRenDO LRenDO commented May 25, 2023

Fixes #4502

What changes did you make and why did you make them ?

  • Updated labels: 'size: 0.25pt' to labels: ['size: 0.25pt', 'role missing', 'Feature Missing', 'Complexity: Missing']
    in .github/ISSUE_TEMPLATE/emergent-request.md
  • Added brackets to list that were not in the code in the original issue to fix linting issue.
  • Verified updates per testing instructions

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied
Visuals after changes are applied

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: Updated Emergent Issue Template

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b LRenDO-update-emergent-request-labels gh-pages
git pull https://github.com/LRenDO/hfla-site.git update-emergent-request-labels

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 25, 2023
@LOSjr4 LOSjr4 self-requested a review May 25, 2023 22:58
Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job following the steps of this issue @LRenDO! Even I wasn't sure how to verify the changes at first, and I've been here a few months.
I checked the link Ren left and verified the correct additions were made. Ren also wrote up a nice description of what was done including screenshots. I also noticed the additional checklist Ren followed in the comment section of the original issue as instructed.
Thank you for the good work Ren!

@ldietz08 ldietz08 self-requested a review May 26, 2023 04:04
@ldietz08
Copy link
Member

ldietz08 commented May 26, 2023

Availability: 5/26-5/27 1pm-4pm
ETA: 5/27

@ldietz08
Copy link
Member

The pull request is done in the correct branch and you linked to the issue. The emergent request markdown file has been updated correctly. Great job!

@t-will-gillis t-will-gillis self-requested a review May 28, 2023 16:46
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LRenDO - Great job! everything looks good: your branches, you linked the issue, your description tells the whats and whys, you included visuals, and your code changes are clean and concise, and when I test the code it adds the correct labels to the new issue.

Thanks!

@t-will-gillis t-will-gillis merged commit 930afce into hackforla:gh-pages May 28, 2023
@LRenDO
Copy link
Member Author

LRenDO commented May 28, 2023

@LOSjr4 @ldietz08 @t-will-gillis Thanks for the specific feedback y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: emergent-request

4 participants