Skip to content

Added labels to blank issue form with dependency yml file#4745

Merged
chrismenke45 merged 1 commit intohackforla:gh-pagesfrom
kiwookim:update-labels-blank-issue-with-dependency-4491
May 31, 2023
Merged

Added labels to blank issue form with dependency yml file#4745
chrismenke45 merged 1 commit intohackforla:gh-pagesfrom
kiwookim:update-labels-blank-issue-with-dependency-4491

Conversation

@kiwookim
Copy link
Member

@kiwookim kiwookim commented May 26, 2023

Fixes #4491

What changes did you make and why did you make them ?

  • added labels to blank-issue-form-with-dependency.yml (labels: ['role missing', 'Complexity: Missing', 'Feature Missing', 'size: missing','Draft'])

Screenshots of Proposed Changes Of The Website

-No Visual Changes

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process
URL of the issue branch on the test Repository: https://github.com/kiwookim/website/issues/new?assignees=&labels=role+missing%2CComplexity%3A+Missing%2CFeature+Missing%2Csize%3A+missing%2CDraft&projects=&template=blank-issue-form-with-dependency.yml
For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kiwookim-update-labels-blank-issue-with-dependency-4491 gh-pages
git pull https://github.com/kiwookim/website.git update-labels-blank-issue-with-dependency-4491

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 26, 2023
@roslynwythe roslynwythe self-requested a review May 26, 2023 20:36
@roslynwythe
Copy link
Member

Availability: 1 hr 5/26
ETA 5/27 EOD

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kiwookim for great work on this issue. Your branches are setup correctly, your code change is correct, and you completed the test procedure and copied the test URL into the PR for reviewers to use. My only tiny request is to make a quick improvement to the description under in the section "What changes did you make.." You might want to list the labels you added for the convenience of the reviewers. The second bullet point is not clear so please expand on it or remove. Thank you.

@kiwookim
Copy link
Member Author

Thank you @kiwookim for great work on this issue. Your branches are setup correctly, your code change is correct, and you completed the test procedure and copied the test URL into the PR for reviewers to use. My only tiny request is to make a quick improvement to the description under in the section "What changes did you make.." You might want to list the labels you added for the convenience of the reviewers. The second bullet point is not clear so please expand on it or remove. Thank you.

Thank you for the review roslyn! I made the changes. Thank you

@kiwookim kiwookim requested a review from roslynwythe May 27, 2023 00:43
@t-will-gillis t-will-gillis requested a review from LOSjr4 May 28, 2023 17:11
@LOSjr4
Copy link
Member

LOSjr4 commented May 28, 2023

Availability: weekdays 9AM-1PM
ETA: 5/29 1PM

Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw how we originally didn't have labels on our blank Issue template and @kiwookim added the 5 labels as stated in their description. Ki followed the guide correctly in submitting this PR and leaving a link for reviews to easily see his branch with the additions. Thank you for taking this issue @kiwookim .

@chrismenke45 chrismenke45 self-requested a review May 31, 2023 14:46
Copy link
Member

@chrismenke45 chrismenke45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The labels show up when using the template!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: blank-issue-form-with-dependency

4 participants