Added labels to blank issue form with dependency yml file#4745
Added labels to blank issue form with dependency yml file#4745chrismenke45 merged 1 commit intohackforla:gh-pagesfrom kiwookim:update-labels-blank-issue-with-dependency-4491
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 1 hr 5/26 |
There was a problem hiding this comment.
Thank you @kiwookim for great work on this issue. Your branches are setup correctly, your code change is correct, and you completed the test procedure and copied the test URL into the PR for reviewers to use. My only tiny request is to make a quick improvement to the description under in the section "What changes did you make.." You might want to list the labels you added for the convenience of the reviewers. The second bullet point is not clear so please expand on it or remove. Thank you.
Thank you for the review roslyn! I made the changes. Thank you |
|
Availability: weekdays 9AM-1PM |
LOSjr4
left a comment
There was a problem hiding this comment.
I saw how we originally didn't have labels on our blank Issue template and @kiwookim added the 5 labels as stated in their description. Ki followed the guide correctly in submitting this PR and leaving a link for reviews to easily see his branch with the additions. Thank you for taking this issue @kiwookim .
chrismenke45
left a comment
There was a problem hiding this comment.
Looks good! The labels show up when using the template!
Fixes #4491
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website
-No Visual Changes
For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers
This URL will be inserted by the dev during the test process
URL of the issue branch on the test Repository: https://github.com/kiwookim/website/issues/new?assignees=&labels=role+missing%2CComplexity%3A+Missing%2CFeature+Missing%2Csize%3A+missing%2CDraft&projects=&template=blank-issue-form-with-dependency.yml
For PM, Merge Team, or Tech Lead