Skip to content

Updated Labels From Missing Series in Suggest a Guide Template Page#4746

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
imvan2:update-suggest-a-guide-4487
May 31, 2023
Merged

Updated Labels From Missing Series in Suggest a Guide Template Page#4746
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
imvan2:update-suggest-a-guide-4487

Conversation

@imvan2
Copy link
Member

@imvan2 imvan2 commented May 26, 2023

Fixes #4487

What changes did you make and why did you make them ?

  • Added labels: ['documentation', 'enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing'] per instructions to .github/ISSUE_TEMPLATE/suggest-a-guide.md per instructions
  • Made the changes so we can avoid Github bot taking off the labels when devs add them to issues

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visuals before changes are applied.

No visual changes to the website. Visuals after changes are applied

update-suggest-a-guide-4487-screenshot

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: (https://github.com/imvan2/website/issues/new?assignees=&labels=documentation%2Cenhancement%2Crole+missing%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=suggest-a-guide.md&title=)

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b imvan2-update-suggest-a-guide-4487 gh-pages
git pull https://github.com/imvan2/website.git update-suggest-a-guide-4487

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 26, 2023
@imvan2 imvan2 changed the title Included more labels per instructions in 4487 Updated Labels From Missing Series in Suggest a Guide Template Page May 26, 2023
@93Belen 93Belen self-requested a review May 26, 2023 21:28
@93Belen
Copy link
Member

93Belen commented May 26, 2023

Availability: Sunday, Monday, Tuesday and Sunday from 6am to 6pm
ETA: Monday by 6pm

Copy link
Member

@93Belen 93Belen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Great job with this PR!

  • The PR is done from the correct branch.
  • You linked the Issues correctly
  • and made the correct changes in the code
  • You did great adding the link for reviewers
  • and making a descriptive title and adding the visual to your description,
  • but I am requesting changes so you can explain in the description why you made these changes. Right now you just say "per instruction" but that doesn't explain much. The reason to make this changes is so that we can avoid the GitHub bot taking off the labels when devs add them to issues.

@imvan2
Copy link
Member Author

imvan2 commented May 26, 2023

Hi @93Belen! Thanks for catching that. I've added the reasoning to my PR.

@93Belen 93Belen self-requested a review May 26, 2023 22:33
Copy link
Member

@93Belen 93Belen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick! thanks!
Next time when you make some requested changes you can request another review by clicking here
Screenshot 2023-05-26 at 5 32 00 PM
You don't need to do it now because I did it :)

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imvan2 - Great job! Your branches are correct, you link to the original issue, your description says what changes you made and why (thank you @93Belen for your review comments and thank you Van for picking those up), and you added a link to the new issue in your repo showing the correct labels.

Thanks!

@rdhmdhl
Copy link
Contributor

rdhmdhl commented May 29, 2023

availability: weekdays 5-9pm; weekends 9-5pm
ETA: 5/31

@rdhmdhl
Copy link
Contributor

rdhmdhl commented May 31, 2023

Hey @imvan2 ! Great job linking the issue, and understanding the testing procedure. The changes you've made to the file look correct. I've used the link you provided to see the labels added -- looks good. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: suggest-a-guide

4 participants