Updated Labels From Missing Series in Suggest a Guide Template Page#4746
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Sunday, Monday, Tuesday and Sunday from 6am to 6pm |
93Belen
left a comment
There was a problem hiding this comment.
Hi! Great job with this PR!
- The PR is done from the correct branch.
- You linked the Issues correctly
- and made the correct changes in the code
- You did great adding the link for reviewers
- and making a descriptive title and adding the visual to your description,
- but I am requesting changes so you can explain in the description why you made these changes. Right now you just say "per instruction" but that doesn't explain much. The reason to make this changes is so that we can avoid the GitHub bot taking off the labels when devs add them to issues.
|
Hi @93Belen! Thanks for catching that. I've added the reasoning to my PR. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @imvan2 - Great job! Your branches are correct, you link to the original issue, your description says what changes you made and why (thank you @93Belen for your review comments and thank you Van for picking those up), and you added a link to the new issue in your repo showing the correct labels.
Thanks!
|
availability: weekdays 5-9pm; weekends 9-5pm |
|
Hey @imvan2 ! Great job linking the issue, and understanding the testing procedure. The changes you've made to the file look correct. I've used the link you provided to see the labels added -- looks good. Approved. |

Fixes #4487
What changes did you make and why did you make them ?
labels: ['documentation', 'enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']per instructions to.github/ISSUE_TEMPLATE/suggest-a-guide.mdper instructionsScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visuals before changes are applied.
Visuals after changes are applied
For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: (https://github.com/imvan2/website/issues/new?assignees=&labels=documentation%2Cenhancement%2Crole+missing%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=suggest-a-guide.md&title=)
For PM, Merge Team, or Tech Lead