Skip to content

Add multiple labels on "Suggest new feature/content" template.#4763

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
AHP15:update-labels-4481
Jun 2, 2023
Merged

Add multiple labels on "Suggest new feature/content" template.#4763
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
AHP15:update-labels-4481

Conversation

@AHP15
Copy link
Contributor

@AHP15 AHP15 commented May 31, 2023

Fixes #4481

What changes did you make and why did I make them?

  • In the file .github/ISSUE_TEMPLATE/suggest-a-feature-or-new-content-for-hackforla-org.md:
    I replace the following line: labels: enhancement, with: labels: ['enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']
  • I followed the instructions in this issue

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: https://github.com/Abdessittir/website/issues/new?assignees=&labels=enhancement%2Crole+missing%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=suggest-a-feature-or-new-content-for-hackforla-org.md&title=

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

File and Code links you will need to work on this issue

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Abdessittir-update-labels-4481 gh-pages
git pull https://github.com/Abdessittir/website.git update-labels-4481

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 31, 2023
@roslynwythe roslynwythe self-requested a review June 1, 2023 02:02
@roslynwythe
Copy link
Member

Availability: 5/31 10 - midnight
ETA EOD 6/1

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Abdessittir this PR looks very good. The branches are setup correctly, the code change is correct and clean, and the template in your test repository displays the correct labels. My only requests are

  • change the title of PR to reflect the fact that you updated the labels on the "Suggest new feature/content" template.
  • copy the URL to the template in your repository, into the PR, replacing this text: [REPLACE THIS TEXT AND BRACKETS WITH THE URL] which can be found under the heading "Link for Reviewers" above
    Thank you!

@AHP15 AHP15 changed the title Add multipe options for labels Add multipe options for labels on "Suggest new feature/content" template. Jun 1, 2023
@AHP15
Copy link
Contributor Author

AHP15 commented Jun 1, 2023

Thanks, changes implemented

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Abdessittir!

Nice work! As @roslynwythe mentioned, the code looks good and it looks like you have made the changes requested. Some of the highlights are below!

  • the PR title has been changed to reflect the update
  • template URL from your repo was added
  • labels appear correctly in the link and match the HackForLA/website repo
  • the issue is linked
  • branches are correct

You may already know this, but I just learned that you can also request a re-review by clicking the refresh circle with arrows next to the reviewer. Shown here in step 3.

Thanks for your contribution!

@roslynwythe roslynwythe changed the title Add multipe options for labels on "Suggest new feature/content" template. Add multiple labels on "Suggest new feature/content" template. Jun 2, 2023
@roslynwythe roslynwythe self-requested a review June 2, 2023 16:41
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Abdessittir for making the request changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: suggest-a-feature-or-new-content-for-hackforla-org

3 participants