Add multiple labels on "Suggest new feature/content" template.#4763
Add multiple labels on "Suggest new feature/content" template.#4763roslynwythe merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 5/31 10 - midnight |
There was a problem hiding this comment.
Hi @Abdessittir this PR looks very good. The branches are setup correctly, the code change is correct and clean, and the template in your test repository displays the correct labels. My only requests are
- change the title of PR to reflect the fact that you updated the labels on the "Suggest new feature/content" template.
- copy the URL to the template in your repository, into the PR, replacing this text: [REPLACE THIS TEXT AND BRACKETS WITH THE URL] which can be found under the heading "Link for Reviewers" above
Thank you!
|
Thanks, changes implemented |
LRenDO
left a comment
There was a problem hiding this comment.
Hi @Abdessittir!
Nice work! As @roslynwythe mentioned, the code looks good and it looks like you have made the changes requested. Some of the highlights are below!
- the PR title has been changed to reflect the update
- template URL from your repo was added
- labels appear correctly in the link and match the HackForLA/website repo
- the issue is linked
- branches are correct
You may already know this, but I just learned that you can also request a re-review by clicking the refresh circle with arrows next to the reviewer. Shown here in step 3.
Thanks for your contribution!
Fixes #4481
What changes did you make and why did I make them?
.github/ISSUE_TEMPLATE/suggest-a-feature-or-new-content-for-hackforla-org.md:I replace the following line:
labels: enhancement, with:labels: ['enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: https://github.com/Abdessittir/website/issues/new?assignees=&labels=enhancement%2Crole+missing%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=suggest-a-feature-or-new-content-for-hackforla-org.md&title=
For PM, Merge Team, or Tech Lead
File and Code links you will need to work on this issue
.github/ISSUE_TEMPLATE/suggest-a-feature-or-new-content-for-hackforla-org.md