Skip to content

Updated Labels project-profile-card-review-and-update-4489#4773

Merged
roslynwythe merged 3 commits intohackforla:gh-pagesfrom
mlkara:project-profile-card-review-and-update-4489
Jun 8, 2023
Merged

Updated Labels project-profile-card-review-and-update-4489#4773
roslynwythe merged 3 commits intohackforla:gh-pagesfrom
mlkara:project-profile-card-review-and-update-4489

Conversation

@mlkara
Copy link
Member

@mlkara mlkara commented Jun 2, 2023

Fixes #4489

What changes did you make and why did you make them ?

  • labels: ['P-Feature: Project Info and Page', 'role: back end/devOps', 'role: front end', ': Complexity: Small', 'size: 0.5pt', 'time sensitive']
  • Modified the project profile card review and updated template.

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository:
https://github.com/mlkara/website/issues/new?assignees=&labels=P-Feature%3A+Project+Info+and+Page%2Crole%3A+back+end%2FdevOps%2Crole%3A+front+end%2CComplexity%3A+Small%2Csize%3A+0.5pt%2Ctime+sensitive&projects=&template=project-profile-card-review-and-update.yml&title=Update+Project+Profile%3A+%5BProject+Name%5D

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

File and Code links you will need to work on this issue

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

  • The Appearance of the website has not changed.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b mlkara-project-profile-card-review-and-update-4489 gh-pages
git pull https://github.com/mlkara/website.git project-profile-card-review-and-update-4489

@roslynwythe roslynwythe self-requested a review June 4, 2023 16:32
@roslynwythe
Copy link
Member

Availability: 6/4 6-8 pm
ETA: EOD 6/4

@Adastros Adastros requested a review from mjshelton12 June 4, 2023 17:13
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mlkara thank you for working on this issue. You may have noticed that above, some GitHub checks were not successful. Our GitHub automation looks at the first line of the PR in order to find the linked issue. Please change the first line to "Fixes #4489".

Please see my Slack DM

@mlkara mlkara changed the title project-profile-card-review-and-update-4489 Update #4489 project-profile-card-review-and-update-4489 Jun 4, 2023
@mlkara mlkara changed the title Update #4489 project-profile-card-review-and-update-4489 Updated Labels project-profile-card-review-and-update-4489 Jun 4, 2023
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels Jun 4, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlkara for linking your issue and PR.

Please delete the 3 lines of text surrounded by double quotes (starting with "For Reviewers and Merge Team" from the PR. Then go to the issue and copy the URL of the test template from this comment into the section of the issue titled "Link for Reviewers", replacing the text: [REPLACE THIS TEXT AND BRACKETS WITH THE URL].
Then go to the issue and copy these entire sections (the headings and the text underneath) of the issue from the issue into the PR:

  • For PR Reviewers and Merge Team
  • Link for Reviewers
  • For PM, Merge Team, or Tech Lead

Thank you!

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlkara for your work on this issue. You setup the branches correctly, made the correct code change, tested the branch, and created a well-formed PR including a link to the original issue and a description of your work.

@JpadillaCoding JpadillaCoding self-requested a review June 8, 2023 05:05
@JpadillaCoding
Copy link
Member

Review ETA: 2 AM 6/8/23
Availability: 12am-5am 6/8/23
(Night Owl)

@JpadillaCoding
Copy link
Member

Hey @mlkara ,

  • Your pull request is coming from the correct branch and is also being requested into the correct branch.
  • The Correct issue is linked
  • The change requested on the issue matches what you've changed on your branch
  • Labels match the updated labels string in the issue when using the reviewer link.
    Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: project-profile-card-review-and-update

3 participants