refrac: updated small label to avoid github bot removing the label

[JpadillaCoding]

Fixes #4479

What changes did you make and why did you make them ?

• labels: ['Complexity: Small','p-feature: SDGs','role: front end','size: 0.25pt']
• Modified the labels on the Creating a yml file for a SDG issue templete

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-No visual changes

###For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

###Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: https://github.com/JpadillaCoding/Website/issues/new?assignees=&labels=Complexity%3A+Small%2Cp-feature%3A+SDGs%2Crole%3A+front+end%2Csize%3A+0.25pt&projects=&template=creating-a-yml-file-for-a-sdg.md&title=Creating+a+yml+file+for+SDG+%5BINSERT+SDG+NUMBER+HERE%5D

###For PM, Merge Team, or Tech Lead

• Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
  • Checking off the dependency for this issue
  • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b JpadillaCoding-modify-small-label-4479 gh-pages
git pull https://github.com/JpadillaCoding/Website.git modify-small-label-4479

[kiwookim]

ETA: 6/4/23 by 3pm

[kiwookim]

Hi, Jose.
Thanks for taking this issue,
Great job setting up the branch correctly, adding correct labels in the 'creating-a-yml-file-for-a-sdg.md.
I do see all the labels you added on the create issue page.

Just a minor fix:
Please remove the bracket when adding links in the few sections where the reviewers need the URL so it redirects us to the URL right when we click on it. (Link for Reviewers, and in the comments section here: #4479 (comment))
Thank you.

[roslynwythe]

Availability: 6/4 6 -8 pm
ETA: EOD 6/4

[JpadillaCoding]

@kiwookim
Nice Catch! The comments have been edited with the removal of the brackets.

[kiwookim]

Could you also add the url here? #4479 (comment) (Link for Reviewers section)

Thank you for the update!

[JpadillaCoding]

@kiwookim It's been added as a comment as requested.

[roslynwythe]

Great job @JpadillaCoding! You made the correct code change, followed the test procedure, and created a Pull Request with the correct branches. We do need to ask that you write something under "What changes did you make and why did you make them ?". I suggest two bullet points, one with the updated value of the "labels" array, and another that mentions that you modified the labels on the "Creating a yml file for a SDG" issue template, so that the GitHub bot won't remove the label.

The sentence "No visual changes" should go under "Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)".

Thank you !

[JpadillaCoding]

@roslynwythe I've made the changes requested. One thing I am curious about- How does commenting the label modification stop the bot from removing the label?

[JpadillaCoding]

Provide Update

1. Progress: Issue complete, making adjustments to PR comment to meet PR request standards.
2. Blockers: N/A
3. Availability: Sunday 7am-9pm
4. ETA: Done

[roslynwythe]

Hi @JpadillaCoding I agree that in this particular issue, it is unclear how the change specified in the Action Item would make a difference in the GitHub bot behavior, since all of the labels in the "Missing Series" were already assigned. The change may have been made to be consistent with the syntax in other issue templates.

Thank you for your work on this issue. You made the correct code change, completed a rather complex test process, and created a well-formed PR. We really appreciate your time and effort!