Skip to content

Changed Project Title in website.md#4817

Merged
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
Abrosss:change-project-title-to-Hack-for-LA-Site-4514
Jun 18, 2023
Merged

Changed Project Title in website.md#4817
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
Abrosss:change-project-title-to-Hack-for-LA-Site-4514

Conversation

@Abrosss
Copy link
Member

@Abrosss Abrosss commented Jun 12, 2023

Fixes #4514

What changes did you make and why did you make them ?

  • Changed 'Hackforla.org Website' Project Title to 'Hack for LA Site' in website.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals on the Current Projects and Website Project pages before changes are applied

image

image

Visuals on the Current Projects and Website Project pages after changes are applied

image
image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Abrosss-change-project-title-to-Hack-for-LA-Site-4514 gh-pages
git pull https://github.com/Abrosss/website.git change-project-title-to-Hack-for-LA-Site-4514

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers Feature: Accessibility Issues that would broaden website accessibility size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 12, 2023
@one2code one2code self-requested a review June 12, 2023 21:16
@one2code
Copy link
Member

ETA: 6/12/23

Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abrosss I've reviewed the changes that you have made for issue #4514, and can verify that the requested merge is into the correct branch, and that the changes you have made to the value in 'title' are correct. I've also verified that the correct title value is displayed during testing in Docker when visiting https://www.hackforla.org/projects & `https://www.hackforla.org/projects/website ' I'm going to request that you check off all of the boxes in issue #4514 before I submit my approval on the pull request, to ensure completeness.

@Abrosss
Copy link
Member Author

Abrosss commented Jun 13, 2023

Alright! Just did it, thank you @one2code

@one2code one2code self-requested a review June 13, 2023 04:01
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job on your first pull request @Abrosss, and thank you for taking the time to check off all of the boxes in the issue.

@steven-positive-tran
Copy link
Member

ETA: 6/14/23

@steven-positive-tran steven-positive-tran self-requested a review June 13, 2023 23:56
@roslynwythe roslynwythe self-requested a review June 14, 2023 18:02
Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good on my machine. Branches are directed correctly and the code change are in line with the issue that was presented.

Thank you for taking up this issue for hack for la and good job.

@graycodesnu graycodesnu self-requested a review June 16, 2023 03:54
@graycodesnu
Copy link
Member

ETA: Evening of 6/14
Availability: 6/14-6/15

Copy link
Member

@graycodesnu graycodesnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Abrosss! Great job working this issue. You committed changes to and from the correct branches, made the necessary changes to the codebase (which runs on my local machine with no issues), and your pull request looks good. Changes approved. Thank you!

@drakenguyen4000
Copy link
Member

Hi @Abrosss, good work! Code was changed properly.

@drakenguyen4000 drakenguyen4000 merged commit 0479a11 into hackforla:gh-pages Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
@bonniewolfe bonniewolfe mentioned this pull request Jun 19, 2023
2 tasks
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change "HackforLA.org" project title to enable proper screen reader pronunciation

5 participants