Changed Project Title in website.md#4817
Changed Project Title in website.md#4817drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom Abrosss:change-project-title-to-Hack-for-LA-Site-4514
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 6/12/23 |
one2code
left a comment
There was a problem hiding this comment.
@Abrosss I've reviewed the changes that you have made for issue #4514, and can verify that the requested merge is into the correct branch, and that the changes you have made to the value in 'title' are correct. I've also verified that the correct title value is displayed during testing in Docker when visiting https://www.hackforla.org/projects & `https://www.hackforla.org/projects/website ' I'm going to request that you check off all of the boxes in issue #4514 before I submit my approval on the pull request, to ensure completeness.
|
Alright! Just did it, thank you @one2code |
|
ETA: 6/14/23 |
steven-positive-tran
left a comment
There was a problem hiding this comment.
Changes look good on my machine. Branches are directed correctly and the code change are in line with the issue that was presented.
Thank you for taking up this issue for hack for la and good job.
|
ETA: Evening of 6/14 |
graycodesnu
left a comment
There was a problem hiding this comment.
Hi, @Abrosss! Great job working this issue. You committed changes to and from the correct branches, made the necessary changes to the codebase (which runs on my local machine with no issues), and your pull request looks good. Changes approved. Thank you!
|
Hi @Abrosss, good work! Code was changed properly. |
Fixes #4514
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals on the Current Projects and Website Project pages before changes are applied
Visuals on the Current Projects and Website Project pages after changes are applied