Skip to content

Check dependabot version updates to move-closed-issue.yml 4824#4832

Merged
t-will-gillis merged 10 commits intohackforla:gh-pagesfrom
t-will-gillis:check-version-updates-4824
Jun 29, 2023
Merged

Check dependabot version updates to move-closed-issue.yml 4824#4832
t-will-gillis merged 10 commits intohackforla:gh-pagesfrom
t-will-gillis:check-version-updates-4824

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Jun 13, 2023

Fixes #4824

What changes did you make and why did you make them ?

  • Tested updating the package versions In the file moved-closed-issues.yml per the dependabot suggestions:
    • Tested changing uses: actions/github-script@v4 with uses: actions/github-script@v6 per 4734
    • Tested changing uses: actions/checkout@v2 with uses: actions/checkout@v3
    • Both changes passed successfully, issues are moved to either 'Done' or 'QA' columns upon closing as they are supposed to.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changes effect GHAs only

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-check-version-updates-4824 gh-pages
git pull https://github.com/t-will-gillis/website.git check-version-updates-4824

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1 pt labels Jun 13, 2023
@t-will-gillis t-will-gillis changed the title Check version updates 4824 Check dependabot version updates to move-closed-issue.yml 4824 Jun 13, 2023
@blulady blulady requested review from mademarc and one2code June 14, 2023 02:15
@one2code
Copy link
Member

ETA: 6/15/23

@mademarc
Copy link
Member

Review ETA: 6/15/2023
Availability: 7:10PM

@one2code
Copy link
Member

@t-will-gillis Can you further expound on the testing protocol? I pushed your branch up to my origin, switched my default branch to your branch, but I was not able to access or link to any project board to test which column a closed issue would be moved to, after being placed on the project board. I can see all of the script updates are correct, but I want to be able to test the issue correctly before approving.

@t-will-gillis
Copy link
Member Author

Hi @one2code yes definitely, thanks for the message.

If you haven’t already done this, you will want to set up a Project Board on your own repo- please see this document and the HfLA wiki pages, especially starting at Tip 6 towards the bottom of the page. (FYI for future GHA testing you also might be able to use Nektos from your CLI. I don’t feel like Nektos is helpful for this particular action but it is good to know about.)

Let me know if you run into any issues or would like to discuss further...

@one2code
Copy link
Member

@t-will-gillis Thank you Will. @blulady shared some documentation links with me. I'll give it another go tomorrow, and if I run into any problems, I will reach out to you.

one2code
one2code previously approved these changes Jun 21, 2023
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the documentation, I was able to successfully clone the project board and implement a secret token for testing. I can verify that new issues are correctly placed on the new issue approval column, and then when closed, they are moved to the QA column as intended. These changes brought forth by Dependabot had no breaking effects when tested, Therefore, I'm going to approve this pull request.

@blulady blulady requested a review from ronaldpaek June 21, 2023 02:17
mademarc
mademarc previously approved these changes Jun 23, 2023
Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @t-will-gillis all the line from 10, 12 & 24 changes are done correctly.

ronaldpaek
ronaldpaek previously approved these changes Jun 28, 2023
Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on my end, was able to fork it and simulate the GHA with Sarah today.

@t-will-gillis t-will-gillis dismissed stale reviews from ronaldpaek, mademarc, and one2code via 9104509 June 28, 2023 17:11
@t-will-gillis t-will-gillis requested a review from one2code June 28, 2023 20:24
@t-will-gillis t-will-gillis merged commit abccd69 into hackforla:gh-pages Jun 29, 2023
@t-will-gillis t-will-gillis deleted the check-version-updates-4824 branch June 29, 2023 15:26
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 13, 2023
…orla#4832)

* Update move-closed-issues.yaml

updating versions

* Update move-closed-issues.yaml

* Update move-closed-issues.yaml

* Update move-closed-issues.yaml

* Update schedule-fri-0700.yml

* Update add-label.js

commented out line 312 timeZoneName

* revert to original schedule-fri-0700.yml

* revert to original add-label.js

* revert to previous move-closed-issues.yaml

* revert to orig. changes to move-closed-issues.yaml
@ExperimentsInHonesty ExperimentsInHonesty added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Aug 31, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify dependabot version updates to GHAs for move-closed-issues.yaml

5 participants