Check dependabot version updates to move-closed-issue.yml 4824#4832
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 6/15/23 |
|
Review ETA: 6/15/2023 |
|
@t-will-gillis Can you further expound on the testing protocol? I pushed your branch up to my origin, switched my default branch to your branch, but I was not able to access or link to any project board to test which column a closed issue would be moved to, after being placed on the project board. I can see all of the script updates are correct, but I want to be able to test the issue correctly before approving. |
|
Hi @one2code yes definitely, thanks for the message. If you haven’t already done this, you will want to set up a Project Board on your own repo- please see this document and the HfLA wiki pages, especially starting at Tip 6 towards the bottom of the page. (FYI for future GHA testing you also might be able to use Nektos from your CLI. I don’t feel like Nektos is helpful for this particular action but it is good to know about.) Let me know if you run into any issues or would like to discuss further... |
|
@t-will-gillis Thank you Will. @blulady shared some documentation links with me. I'll give it another go tomorrow, and if I run into any problems, I will reach out to you. |
one2code
left a comment
There was a problem hiding this comment.
After reading the documentation, I was able to successfully clone the project board and implement a secret token for testing. I can verify that new issues are correctly placed on the new issue approval column, and then when closed, they are moved to the QA column as intended. These changes brought forth by Dependabot had no breaking effects when tested, Therefore, I'm going to approve this pull request.
mademarc
left a comment
There was a problem hiding this comment.
Hey @t-will-gillis all the line from 10, 12 & 24 changes are done correctly.
ronaldpaek
left a comment
There was a problem hiding this comment.
Everything looks good on my end, was able to fork it and simulate the GHA with Sarah today.
9104509
commented out line 312 timeZoneName
…orla#4832) * Update move-closed-issues.yaml updating versions * Update move-closed-issues.yaml * Update move-closed-issues.yaml * Update move-closed-issues.yaml * Update schedule-fri-0700.yml * Update add-label.js commented out line 312 timeZoneName * revert to original schedule-fri-0700.yml * revert to original add-label.js * revert to previous move-closed-issues.yaml * revert to orig. changes to move-closed-issues.yaml
Fixes #4824
What changes did you make and why did you make them ?
moved-closed-issues.ymlper the dependabot suggestions:uses: actions/github-script@v4withuses: actions/github-script@v6per 4734uses: actions/checkout@v2withuses: actions/checkout@v3Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Changes effect GHAs only