Skip to content

Check dependabot version updates to schedule-fri-0700.yml 4827#4836

Merged
t-will-gillis merged 8 commits intohackforla:gh-pagesfrom
t-will-gillis:check-version-updates-4827
Jun 30, 2023
Merged

Check dependabot version updates to schedule-fri-0700.yml 4827#4836
t-will-gillis merged 8 commits intohackforla:gh-pagesfrom
t-will-gillis:check-version-updates-4827

Conversation

@t-will-gillis
Copy link
Member

Fixes #4827

What changes did you make and why did you make them ?

  • Tested updating the package versions in the file schedule-fri-0700.yml per the dependabot suggestions:
    • Tested changing uses: actions/github-script@v4 with uses: actions/github-script@v6 per 4734
    • Tested changing uses: actions/checkout@v2 with uses: actions/checkout@v3 per 4735
    • The test changing both versions at same time logged a successful run, however the action did not execute as expected. Additional testing showed that updating uses: actions/github-script@v4 effects the performance of the GHA and we should not update this file to the new version. The other update appears to be OK.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changes effect GHAs only

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-check-version-updates-4827 gh-pages
git pull https://github.com/t-will-gillis/website.git check-version-updates-4827

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1 pt labels Jun 14, 2023
@mademarc
Copy link
Member

Review ETA: 6/22/2023
Availability: 7:14PM

mademarc
mademarc previously approved these changes Jun 23, 2023
Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @t-will-gillis the changes are doe correctly and done properly well.

@matthewmpan
Copy link
Member

Availability: M-F 12PM-5PM
ETA: EOD 6/29/23

Copy link
Member

@matthewmpan matthewmpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @t-will-gillis Thanks for taking on this issue. Your updates in linked issue #4827 show that actions/checkout can be updated from v2 to v3 and that actions/github-script should not be updated from v4 to v6. I went over the proposed changes with you and confirmed that the update is approved for implementation. Great work on this PR, Will!

@t-will-gillis t-will-gillis merged commit c5afaab into hackforla:gh-pages Jun 30, 2023
@t-will-gillis t-will-gillis deleted the check-version-updates-4827 branch June 30, 2023 17:39
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 13, 2023
…orla#4836)

* Update schedule-fri-0700.yml

* Update schedule-fri-0700.yml

* Update schedule-fri-0700.yml

* Update schedule-fri-0700.yml

* Update add-label.js

testing

* Update schedule-fri-0700.yml

* revert to orig. changes schedule-fri-0700.yml

* revert to orig changes to 4827
@ExperimentsInHonesty ExperimentsInHonesty added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Aug 31, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify dependabot version updates to GHAs for schedule-fri-0700.yml

4 participants