Fix citizen engagement logo 4226#4842
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
|
Review ETA: 6 PM 6/17/23 |
|
Availability- M-F 11am - 3 pm |
bonniewolfe
left a comment
bonniewolfe
left a comment
There was a problem hiding this comment.
Please update the video of the Visuals after changes are applied to include what it will look like in mobile.
Also, this was the first time I got a chance to see the animated gif vs the .mov, and the .gif file loaded much faster.
|
Added mobile view to pull request and converted .mov to gif |
Thinking-Panda
left a comment
Thinking-Panda
left a comment
There was a problem hiding this comment.
@jch1013 Nice work with the issue. Merge branches are good. Code changes are applicable and clean. Website works fine on the local machine. Thank you for the work!
ronaldpaek
left a comment
ronaldpaek
left a comment
There was a problem hiding this comment.
Everything looks good to me, image updated and works perfectly even on mobile! 👍
roslynwythe
dismissed
bonniewolfe’s stale review
verbal approval given at meeting 6/25
* Update image and image scss * Update scss to scale image with browser width
* Update image and image scss * Update scss to scale image with browser width
5 participants
Fixes #4226
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
Desktop View
Mobile View
