Skip to content

Check dependabot version update to vrms-data.yml 4829#4846

Merged
t-will-gillis merged 3 commits intohackforla:gh-pagesfrom
t-will-gillis:check-version-updates-4829
Jun 28, 2023
Merged

Check dependabot version update to vrms-data.yml 4829#4846
t-will-gillis merged 3 commits intohackforla:gh-pagesfrom
t-will-gillis:check-version-updates-4829

Conversation

@t-will-gillis
Copy link
Member

Fixes #4829

What changes did you make and why did you make them ?

  • Tested updating the package version in the file vrms-data.yml per the dependabot suggestions:
    • Tested changing uses: actions/checkout@v2 with uses: actions/checkout@v3 per 4735
    • The test changing the actions/checkout@v2 to @v3 was successful- the vrms data was created. The previous 'node deprecation' warning is also removed.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visual of current HfLA VRMS action

4829_vrms-data-hfla

Visual of successful test after version update

4829_vrms-data

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-check-version-updates-4829 gh-pages
git pull https://github.com/t-will-gillis/website.git check-version-updates-4829

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1 pt labels Jun 16, 2023
@roslynwythe roslynwythe self-requested a review June 20, 2023 07:56
@roslynwythe
Copy link
Member

Availability: 6/20 2 - 4 pm
ETA 6/21 EOD

@LRenDO LRenDO self-requested a review June 20, 2023 17:24
@LRenDO
Copy link
Member

LRenDO commented Jun 20, 2023

Availability: 6/20/23 11am-3pm
ETA: 6/21/23

LRenDO
LRenDO previously approved these changes Jun 20, 2023
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @t-will-gillis!

Your pull request looks great! It took me a bit to sort out, but after figuring out how to set up a PAT secret on my fork, I was able to verify that Update VRMS data GHA workflow ran successfully.

Some of the good work highlights:

  • the issue was linked
  • the to and from branches are correct
  • the what is described
  • workflow runs correctly

Minor, non-functional suggestions

  • remove extra space before the last two curly braces in the line with the comment replace
    token: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }} with token: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }}
  • add a # in front of 4735 so that it reads #4735 in the pull request so to make it easier to navigate to the page

Great work and thank you for your contribution!

@blulady blulady self-requested a review June 21, 2023 02:14
roslynwythe
roslynwythe previously approved these changes Jun 22, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branches are setup correctly and the PR is descriptive. I pushed the branch to my repo, made it default, edited the repo and and secret name in vrms-data.yml, then triggered the workflow manually and observed the updated time on vrms_data.json. Great job!

removed excess white space after token line 18
@t-will-gillis t-will-gillis dismissed stale reviews from roslynwythe and LRenDO via ee9f5e1 June 23, 2023 17:13
@t-will-gillis t-will-gillis requested a review from LRenDO June 23, 2023 17:16
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the minor edit fixing the extra space here. Looks great. Thanks @t-will-gillis!

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@t-will-gillis t-will-gillis merged commit a5e946a into hackforla:gh-pages Jun 28, 2023
@t-will-gillis t-will-gillis deleted the check-version-updates-4829 branch June 28, 2023 20:39
@roslynwythe roslynwythe removed the request for review from blulady June 28, 2023 20:43
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 13, 2023
* Update vrms-data.yml

* Update vrms-data.yml

* Update vrms-data.yml

removed excess white space after token line 18
@ExperimentsInHonesty ExperimentsInHonesty added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Aug 31, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify dependabot version updates to GHAs for vrms-data.yml

4 participants