Check dependabot version update to vrms-data.yml 4829#4846
Check dependabot version update to vrms-data.yml 4829#4846t-will-gillis merged 3 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 6/20 2 - 4 pm |
|
Availability: 6/20/23 11am-3pm |
There was a problem hiding this comment.
Hi @t-will-gillis!
Your pull request looks great! It took me a bit to sort out, but after figuring out how to set up a PAT secret on my fork, I was able to verify that Update VRMS data GHA workflow ran successfully.
Some of the good work highlights:
- the issue was linked
- the to and from branches are correct
- the what is described
- workflow runs correctly
Minor, non-functional suggestions
- remove extra space before the last two curly braces in the line with the comment replace
token: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }}withtoken: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }} - add a # in front of 4735 so that it reads
#4735in the pull request so to make it easier to navigate to the page
Great work and thank you for your contribution!
There was a problem hiding this comment.
The branches are setup correctly and the PR is descriptive. I pushed the branch to my repo, made it default, edited the repo and and secret name in vrms-data.yml, then triggered the workflow manually and observed the updated time on vrms_data.json. Great job!
removed excess white space after token line 18
LRenDO
left a comment
There was a problem hiding this comment.
I see the minor edit fixing the extra space here. Looks great. Thanks @t-will-gillis!
* Update vrms-data.yml * Update vrms-data.yml * Update vrms-data.yml removed excess white space after token line 18
Fixes #4829
What changes did you make and why did you make them ?
vrms-data.ymlper the dependabot suggestions:uses: actions/checkout@v2withuses: actions/checkout@v3per 4735actions/checkout@v2to@v3was successful- the vrms data was created. The previous 'node deprecation' warning is also removed.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visual of current HfLA VRMS action
Visual of successful test after version update