dev template label update#4879
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 6/25/23 |
one2code
left a comment
There was a problem hiding this comment.
Good naming convention for the issue branch, and the requested branch to merge into is correct. I've also verified that after clicking the link provided by @whitneywind, all of the updated labels correctly display by default.
Good job on your pull request and excellent attention to detail!
|
Hi @whitneywind since this issue was written, there have been some changes to the labelling of prework issues, and so we may need to change the required |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @whitneywind - My apologies- I gave you the wrong information. This line should be changed to:
labels: ['Feature: Onboarding/Contributing.md', 'Complexity: Prework', 'prework', 'size: 1pt', 'role missing', 'Draft']
and not what I told you previously. Sorry for giving you incorrect info!
|
I'll be sure to update my review to account for the changes.
…On Mon., Jun. 26, 2023, 3:46 p.m. Will Gillis, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @whitneywind <https://github.com/whitneywind> - My apologies- I gave
you the wrong information. This line should be changed to:
labels: ['Feature: Onboarding/Contributing.md', 'Complexity: Prework', 'prework', 'size: 1pt', 'role missing', 'Draft']
and not what I told you previously. Sorry for giving you incorrect info!
—
Reply to this email directly, view it on GitHub
<#4879 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKVNQU2DZI5X2QR6X6SVAALXNHRJ3ANCNFSM6AAAAAAZSJINME>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
one2code
left a comment
There was a problem hiding this comment.
@whitneywind I've reviewed the latest changes, and have verified that you have updated the labels to @t-will-gillis latest comment. Excellent job on quickly updating the labels to the needs of the project.
roslynwythe
left a comment
There was a problem hiding this comment.
Hi @whitneywind I just realized that I need to request another change in the labels. I have updated the Action Items on the issue to omit the Draft label. You will have to push a new commit to your fork, re-check the Action Item checkbox and click the "re-review" icon in the PR. I apologize for missing this problem in my first review, and I thank you for your patience.
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @whitneywind Great job! I am seeing the correct labels applied on the link you provided. Otherwise, your branches are correct, your description is good. Thank you for your patience!
There was a problem hiding this comment.
Thank you @whitneywind for your excellent work on this issue and for making the requested changes. I do apologize that we did not recognize the problem with the issue until you had submitted the PR.
* template label update * latest label change update
Fixes #4478
What changes did you make?
For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers. - UPDATED 6/29
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: https://github.com/whitneywind/website/issues/new?assignees=&labels=Feature%3A+Onboarding%2FContributing.md%2Cprework%2Csize%3A+1pt%2Crole+missing%2CComplexity%3A+Prework&projects=&template=pre-work-template--dev.md&title=Pre-work+Checklist%3A+Developer%3A+%5Breplace+brackets+with+your+name%5D
For PM, Merge Team, or Tech Lead
Once the pull request associated with this issue is approved and merged, please update and edit epic #4307 by
Checking off the dependency for this issue
If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label