Skip to content

dev template label update#4879

Merged
roslynwythe merged 6 commits intohackforla:gh-pagesfrom
whitneywind:update-label-template-4478
Jul 6, 2023
Merged

dev template label update#4879
roslynwythe merged 6 commits intohackforla:gh-pagesfrom
whitneywind:update-label-template-4478

Conversation

@whitneywind
Copy link
Member

@whitneywind whitneywind commented Jun 24, 2023

Fixes #4478

What changes did you make?

  • updated labels in ".github/ISSUE_TEMPLATE/pre-work-template--dev.md"

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers. - UPDATED 6/29
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: https://github.com/whitneywind/website/issues/new?assignees=&labels=Feature%3A+Onboarding%2FContributing.md%2Cprework%2Csize%3A+1pt%2Crole+missing%2CComplexity%3A+Prework&projects=&template=pre-work-template--dev.md&title=Pre-work+Checklist%3A+Developer%3A+%5Breplace+brackets+with+your+name%5D

For PM, Merge Team, or Tech Lead

Once the pull request associated with this issue is approved and merged, please update and edit epic #4307 by
Checking off the dependency for this issue
If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels Jun 24, 2023
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b whitneywind-update-label-template-4478 gh-pages
git pull https://github.com/whitneywind/website.git update-label-template-4478

@one2code one2code self-requested a review June 25, 2023 03:12
@one2code
Copy link
Member

ETA: 6/25/23

one2code
one2code previously approved these changes Jun 25, 2023
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good naming convention for the issue branch, and the requested branch to merge into is correct. I've also verified that after clicking the link provided by @whitneywind, all of the updated labels correctly display by default.

Good job on your pull request and excellent attention to detail!

@roslynwythe roslynwythe self-requested a review June 25, 2023 17:10
@roslynwythe
Copy link
Member

Hi @whitneywind since this issue was written, there have been some changes to the labelling of prework issues, and so we may need to change the required labels string. I will confirm with PM and report back on 6/27. I apologize for the delay.

@roslynwythe roslynwythe mentioned this pull request Jun 25, 2023
2 tasks
@t-will-gillis t-will-gillis self-requested a review June 26, 2023 19:42
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @whitneywind - My apologies- I gave you the wrong information. This line should be changed to:

labels: ['Feature: Onboarding/Contributing.md', 'Complexity: Prework', 'prework', 'size: 1pt', 'role missing',  'Draft']

and not what I told you previously. Sorry for giving you incorrect info!

@one2code
Copy link
Member

one2code commented Jun 26, 2023 via email

@one2code one2code self-requested a review June 26, 2023 23:49
one2code
one2code previously approved these changes Jun 27, 2023
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitneywind I've reviewed the latest changes, and have verified that you have updated the labels to @t-will-gillis latest comment. Excellent job on quickly updating the labels to the needs of the project.

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @whitneywind I just realized that I need to request another change in the labels. I have updated the Action Items on the issue to omit the Draft label. You will have to push a new commit to your fork, re-check the Action Item checkbox and click the "re-review" icon in the PR. I apologize for missing this problem in my first review, and I thank you for your patience.

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @whitneywind Great job! I am seeing the correct labels applied on the link you provided. Otherwise, your branches are correct, your description is good. Thank you for your patience!

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @whitneywind for your excellent work on this issue and for making the requested changes. I do apologize that we did not recognize the problem with the issue until you had submitted the PR.

@roslynwythe roslynwythe merged commit 65cb7d8 into hackforla:gh-pages Jul 6, 2023
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 13, 2023
* template label update

* latest label change update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: pre-work-template--dev

4 participants