Skip to content

Check dependabot suggested version updates to GHA issue-trigger.yml#4905

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
t-will-gillis:check-dependabot-issue-trigger-4822
Jul 9, 2023
Merged

Check dependabot suggested version updates to GHA issue-trigger.yml#4905
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
t-will-gillis:check-dependabot-issue-trigger-4822

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Jul 2, 2023

Fixes #4822

What changes did you make?

Why did you make the changes (we will use this info to test)?

  • These tests were for checking whether we should accepts the Dependabot-suggested updates to misc. packages in the "issue-trigger.yml" file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshot showing successful run of "issue-trigger.yml" accepting the revisions per 4735 and 4737: The labels and message are added.

4822_run_4735+4737_1

Screenshot showing successful run of "issue-trigger.yml" accepting the revisions per 4735 and 4737 post-assignee: the update reminder message is added to the issue.

4822_run_4735+4737_2

Screenshot showing failed run of "issue-trigger.yml" when accepting revisions per 4734: The labels and message are not added.

4822_run_4735+4737_part_ 4734

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-check-dependabot-issue-trigger-4822 gh-pages
git pull https://github.com/t-will-gillis/website.git check-dependabot-issue-trigger-4822

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1 pt labels Jul 2, 2023
@one2code one2code self-requested a review July 4, 2023 21:58
@one2code
Copy link
Member

one2code commented Jul 4, 2023

ETA: 7/7/23

Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the three updates suggested by Dependabot and can verify that 1 and 2 pass, and that 3 currently fails, throwing the following in the Check Labels log, despite showing a pass test case.

Error editing labels: TypeError: Cannot read properties of undefined (reading 'setLabels') at addLabels (/home/runner/work/website/website/github-actions/trigger-issue/add-missing-labels-to-issues/check-labels.js:99:41) at main (/home/runner/work/website/website/github-actions/trigger-issue/add-missing-labels-to-issues/check-labels.js:26:24) at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:[15](https://github.com/one2code/website/actions/runs/5501094086/jobs/10024442689#step:3:16)143:[16](https://github.com/one2code/website/actions/runs/5501094086/jobs/10024442689#step:3:17)), <anonymous>:4:21) at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15144:12) at main (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15236:26) at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:152[17](https://github.com/one2code/website/actions/runs/5501094086/jobs/10024442689#step:3:18):1 at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:15268:3 at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15271:12) at Module._compile (node:internal/modules/cjs/loader:1105:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)

@t-will-gillis did a great job at extensively testing these suggested updates and looking beyond the pass / fail part of the test, which can sometimes be misleading.

@t-will-gillis t-will-gillis merged commit 8138c96 into hackforla:gh-pages Jul 9, 2023
@t-will-gillis t-will-gillis deleted the check-dependabot-issue-trigger-4822 branch July 9, 2023 20:04
t-will-gillis added a commit that referenced this pull request Jul 11, 2023
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 13, 2023
…ackforla#4905)

* checking dependabot recommended updates

* Update issue-trigger.yml
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 16, 2023
…ackforla#4905)

* checking dependabot recommended updates

* Update issue-trigger.yml
@ExperimentsInHonesty ExperimentsInHonesty added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Aug 31, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify dependabot version updates to GHAs for issue-trigger.yml

3 participants