Check dependabot suggested version updates to GHA issue-trigger.yml#4905
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 7/7/23 |
one2code
left a comment
There was a problem hiding this comment.
I've reviewed the three updates suggested by Dependabot and can verify that 1 and 2 pass, and that 3 currently fails, throwing the following in the Check Labels log, despite showing a pass test case.
Error editing labels: TypeError: Cannot read properties of undefined (reading 'setLabels') at addLabels (/home/runner/work/website/website/github-actions/trigger-issue/add-missing-labels-to-issues/check-labels.js:99:41) at main (/home/runner/work/website/website/github-actions/trigger-issue/add-missing-labels-to-issues/check-labels.js:26:24) at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:[15](https://github.com/one2code/website/actions/runs/5501094086/jobs/10024442689#step:3:16)143:[16](https://github.com/one2code/website/actions/runs/5501094086/jobs/10024442689#step:3:17)), <anonymous>:4:21) at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15144:12) at main (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15236:26) at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:152[17](https://github.com/one2code/website/actions/runs/5501094086/jobs/10024442689#step:3:18):1 at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:15268:3 at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15271:12) at Module._compile (node:internal/modules/cjs/loader:1105:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
@t-will-gillis did a great job at extensively testing these suggested updates and looking beyond the pass / fail part of the test, which can sometimes be misleading.
…ackforla#4905) * checking dependabot recommended updates * Update issue-trigger.yml
…ackforla#4905) * checking dependabot recommended updates * Update issue-trigger.yml
Fixes #4822
What changes did you make?
actions/checkout@v2toactions/checkout@v3per Bump actions/checkout from 2 to 3 #4735, these changes are OKtspascoal/get-user-teams-membership@v1totspascoal/get-user-teams-membership@v2per Bump tspascoal/get-user-teams-membership from 1 to 2 #4737, this change is OKtactions/github-script@v4toactions/github-script@v6per Bump actions/github-script from 4 to 6 #4734, this change is NG and should not be madeWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Screenshot showing successful run of "issue-trigger.yml" accepting the revisions per 4735 and 4737: The labels and message are added.
Screenshot showing successful run of "issue-trigger.yml" accepting the revisions per 4735 and 4737 post-assignee: the update reminder message is added to the issue.
Screenshot showing failed run of "issue-trigger.yml" when accepting revisions per 4734: The labels and message are not added.