Skip to content

Update sch fri 4946#4947

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
t-will-gillis:update-sch-fri-4946
Jul 16, 2023
Merged

Update sch fri 4946#4947
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
t-will-gillis:update-sch-fri-4946

Conversation

@t-will-gillis
Copy link
Member

Fixes #4946

What changes did you make?

  • Updated actions/github-script@v4 to actions/github-script@v6
  • When updating the above, github REST methods requests needed to change from github.issues to github.rest.issues

Why did you make the changes (we will use this info to test)?

  • Changes were made so that actions/github-script version can be updated to latest

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visuals

update actions/github-script to @v6
update github/action-script to v6
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-update-sch-fri-4946 gh-pages
git pull https://github.com/t-will-gillis/website.git update-sch-fri-4946

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.5pt Can be done in 3 hours or less labels Jul 13, 2023
@LRenDO LRenDO self-requested a review July 13, 2023 21:38
@LRenDO
Copy link
Member

LRenDO commented Jul 13, 2023

Availability: 7/15 before 3pm
ETA: 7/16
(edited because I put the wrong dates in)

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-will-gillis this update looks great!

  • Branch is set up correctly
  • The what and the why is described in the PR
  • Only changes made were the necessary ones
  • Manual testing showed that appropriate labels were removed and added and that the comments were added correctly as well

Nice work! Thanks for taking the time to get the new versions working correctly!

@t-will-gillis t-will-gillis merged commit 504effc into hackforla:gh-pages Jul 16, 2023
@t-will-gillis t-will-gillis deleted the update-sch-fri-4946 branch July 16, 2023 04:51
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 19, 2023
* Update schedule-fri-0700.yml

update actions/github-script to @v6

* Update add-label.js

update github/action-script to v6
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correction to verify dependabot-suggested version update to GHA schedule-fri-0700.yml

3 participants