Skip to content

refactor-current-projects-4860#5034

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis:refactor-current-projects-4860
Jul 20, 2023
Merged

refactor-current-projects-4860#5034
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis:refactor-current-projects-4860

Conversation

@t-will-gillis
Copy link
Member

Fixes #4860

What changes did you make?

  • Refactored the code in current-projects.js so that "Tools:" renders correctly for each project whether the data is in string or list format.

Why did you make the changes (we will use this info to test)?

  • This change is made so that we willl eventually be able to convert the tools data to a list in the markdown files for all projects.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

There are no visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-refactor-current-projects-4860 gh-pages
git pull https://github.com/t-will-gillis/website.git refactor-current-projects-4860

@github-actions github-actions bot added role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less labels Jul 19, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @t-will-gillis for completing this PR. The branches are correct, the PR is descriptive, the code change is clean and correct and checks out in the browser. It was tested using both string and array versions of the tools variable in home-unite-us.md

Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working fine for me.

@t-will-gillis t-will-gillis merged commit 21153c2 into hackforla:gh-pages Jul 20, 2023
@t-will-gillis t-will-gillis deleted the refactor-current-projects-4860 branch July 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor current-projects file to fix any formatting issue with new tools data format

3 participants