Skip to content

Update Lucky Parking tools from string to list#5061

Merged
adrianang merged 1 commit intohackforla:gh-pagesfrom
mshirk2:refactor-tools-for-lucky-parking-4809
Jul 29, 2023
Merged

Update Lucky Parking tools from string to list#5061
adrianang merged 1 commit intohackforla:gh-pagesfrom
mshirk2:refactor-tools-for-lucky-parking-4809

Conversation

@mshirk2
Copy link
Member

@mshirk2 mshirk2 commented Jul 25, 2023

Fixes #4809

What changes did you make and why did you make them?

  • Updated tools in lucky-parking.md from a string to a list

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes made to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b mshirk2-refactor-tools-for-lucky-parking-4809 gh-pages
git pull https://github.com/mshirk2/website.git refactor-tools-for-lucky-parking-4809

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 25, 2023
@kwangric kwangric self-requested a review July 26, 2023 00:32
@kwangric
Copy link
Member

ETA: EOD 7/26
Availability: After 5pm PDT

@Adastros Adastros requested review from bphan002 and mademarc July 26, 2023 02:15
@bphan002
Copy link
Member

ETA: Wednesday July 26th EOD

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly and the request changes to the code were made. Everything look correct in Docker.

One minor note about the PR is that more details can be added in the description for why the changes needed to be made. But other than that, great work!

Copy link
Member

@bphan002 bphan002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change was exactly as it should be. Everything is loading properly and functional. Great work!

@LRenDO
Copy link
Member

LRenDO commented Jul 27, 2023

Hi @mademarc! If you still would like to review this request, please add your ETA and Availability when you get a minute. If not, please remove yourself as a reviewer. Thanks!

@mademarc
Copy link
Member

Review ETA: 7/27/2023
Availability: 7:16PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mshirk2 Great job on changes that was required and next time do some screenshots of the work that you have done to show exactly how you did it and @LRenDO the ETA and Review is done.

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mshirk2 — the branching is set up correctly, the corresponding issue is linked, and the requested change of making the tools for Lucky Parking into a list. In testing your branch on my local machine, the project page is still rendering the same (as expected).

Thank you for taking up this issue! 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for lucky-parking.md

6 participants