Skip to content

refactored tools data for access-the-data.md#5093

Merged
adrianang merged 1 commit intohackforla:gh-pagesfrom
Tomomi-K1:refactor-tools-data-4798
Jul 29, 2023
Merged

refactored tools data for access-the-data.md#5093
adrianang merged 1 commit intohackforla:gh-pagesfrom
Tomomi-K1:refactor-tools-data-4798

Conversation

@Tomomi-K1
Copy link
Member

@Tomomi-K1 Tomomi-K1 commented Jul 26, 2023

Fixes #4798

What changes did you make?

  • on access-the-data.md file under _project file, I changed tools data from string to a list as it is described on issue action item.

Why did you make the changes (we will use this info to test)?

-We need to revise the filter menu on the projects-check page to include a dropdown for "Tools", so that we can see where we might need to move project values from tools to technologies, and vice versa. In order for the filter to work properly, we need to refactor the tools data in the .md file from a string to a list.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Tomomi-K1-refactor-tools-data-4798 gh-pages
git pull https://github.com/Tomomi-K1/website.git refactor-tools-data-4798

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 26, 2023
@LRenDO LRenDO self-requested a review July 27, 2023 05:41
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tomomi-K1! This looks great! Nice work!

  • The branching was done correctly with the issue number
  • The title is descriptive
  • The changes were made correctly and display correctly on the site
  • Nothing additional was changed
  • The "what" was very descriptive
  • Appropriate screenshots were included with helpful highlighting

I have one minor request. Please add a section about why the changes were made. Often times you can find the reason why the change is being made in the original issue.

Once you've made the change, you can click the circle with the arrows next to my username in the Reviewers section of this page. This will re-request a review.

Thank you for taking the time to contribute to the site!

@Tomomi-K1 Tomomi-K1 requested a review from LRenDO July 27, 2023 18:33
@Tomomi-K1
Copy link
Member Author

@LRenDO Thank you so much for checking my first pull request! I have added why changes were made section. Let me know if I need to change anything! I'm happy to contribute and get more experiences!

@kwangric kwangric self-requested a review July 27, 2023 20:53
@kwangric
Copy link
Member

ETA: EOD 7/27

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks great @Tomomi-K1! Thanks again and great job!

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like branches are set up correctly and the requested changes to the code were made. Everything look good in Docker as well. Great work!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tomomi-K1 — the branching is set up correctly, the corresponding issue is linked, and the requested change was made to exactly what was asked of (making the tools for Access the Data into a list from a string). When I tested your branch on my local machine via Docker, the Access the Data project page looked the same, as expected.

I would also say that since this issue didn't really have a visual change, the screenshots aren't really needed and could be either deleted or noted that there weren't visual changes, but this is just something minor to keep in mind for your next issues if they also don't have visual changes.

Thank you for taking up this issue! 🙌🏼

@adrianang adrianang merged commit c061ab6 into hackforla:gh-pages Jul 29, 2023
@Tomomi-K1
Copy link
Member Author

Hi @adrianang ,

Thank you for checking and approving my issue! I will keep in mind that I don't need to add images if there is no visual change.
This time, there was actually minor visual change, but the difference is only quotation mark. :)

Thank you again for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for access-the-data.md

4 participants