refactored tools data for access-the-data.md#5093
refactored tools data for access-the-data.md#5093adrianang merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
LRenDO
left a comment
There was a problem hiding this comment.
Hi @Tomomi-K1! This looks great! Nice work!
- The branching was done correctly with the issue number
- The title is descriptive
- The changes were made correctly and display correctly on the site
- Nothing additional was changed
- The "what" was very descriptive
- Appropriate screenshots were included with helpful highlighting
I have one minor request. Please add a section about why the changes were made. Often times you can find the reason why the change is being made in the original issue.
Once you've made the change, you can click the circle with the arrows next to my username in the Reviewers section of this page. This will re-request a review.
Thank you for taking the time to contribute to the site!
|
@LRenDO Thank you so much for checking my first pull request! I have added |
|
ETA: EOD 7/27 |
There was a problem hiding this comment.
Update looks great @Tomomi-K1! Thanks again and great job!
kwangric
left a comment
There was a problem hiding this comment.
Looks like branches are set up correctly and the requested changes to the code were made. Everything look good in Docker as well. Great work!
adrianang
left a comment
There was a problem hiding this comment.
Hi @Tomomi-K1 — the branching is set up correctly, the corresponding issue is linked, and the requested change was made to exactly what was asked of (making the tools for Access the Data into a list from a string). When I tested your branch on my local machine via Docker, the Access the Data project page looked the same, as expected.
I would also say that since this issue didn't really have a visual change, the screenshots aren't really needed and could be either deleted or noted that there weren't visual changes, but this is just something minor to keep in mind for your next issues if they also don't have visual changes.
Thank you for taking up this issue! 🙌🏼
|
Hi @adrianang , Thank you for checking and approving my issue! I will keep in mind that I don't need to add images if there is no visual change. Thank you again for your time! |
Fixes #4798
What changes did you make?
access-the-data.mdfile under_projectfile, I changedtoolsdata from string to a list as it is described on issue action item.Why did you make the changes (we will use this info to test)?
-We need to revise the filter menu on the projects-check page to include a dropdown for "Tools", so that we can see where we might need to move project values from tools to technologies, and vice versa. In order for the filter to work properly, we need to refactor the tools data in the .md file from a string to a list.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied