Skip to content

Refactor Tools data for open-community-survey.md#5096

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
yffu:refactor-tools-data-4811
Jul 27, 2023
Merged

Refactor Tools data for open-community-survey.md#5096
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
yffu:refactor-tools-data-4811

Conversation

@yffu
Copy link
Contributor

@yffu yffu commented Jul 26, 2023

Fixes #4811

What changes did you make?

  • update of open-community-survey.md tools data from a string to a list
  • current-projects-check.js the clause where project.tools is set is still in single quotes, removed quotes so json is an array instead of string literal

Why did you make the changes (we will use this info to test)?

  • so it displays correctly on all projects pages for the community survey card

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

refactor-tools-data-4811_0

Visuals after changes are applied

refactor-tools-data-4811_1
but even with the suggested changes on #4811 tools displays as a string representation of a list, and not a comma separated list. On review of #4861 one of the dependencies for #4811 I discovered that in current-projects-check.js the clause where project.tools is set is still in single quotes. On removing the single quotes tools displays as a comma separated list.

refactor-tools-data-4811_3

… so it displays correctly on all projects pages for the community survey card
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b yffu-refactor-tools-data-4811 gh-pages
git pull https://github.com/yffu/website.git refactor-tools-data-4811

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 26, 2023
@yffu yffu removed the role: back end/devOps Tasks for back-end developers label Jul 26, 2023
…mmunity-survey.md, remove quotes around project.tools json so tools displays as list and not as string representation of list
@github-actions github-actions bot added the role: back end/devOps Tasks for back-end developers label Jul 26, 2023
@steven-positive-tran steven-positive-tran self-requested a review July 27, 2023 01:18
@steven-positive-tran
Copy link
Member

steven-positive-tran commented Jul 27, 2023

Review ETA: 7/26 EOD
Availability: 7/26 6-12

Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches look good, Code changes seem in line with the issue needed to be fixed and works on my machine.

Thank you for taking this issue for hackforla.

@t-will-gillis t-will-gillis self-requested a review July 27, 2023 20:47
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yffu - Awesome job on your first issue! Your branches are correct, you linked the original issue, you explained the whats and the whys, and you provided the visuals of the before and after changes.

Bonus points for noticing the issue with current-projects-check.js. It is great and we definitely appreciate that you noticed the problem. If you see something like this in the future, however, PLEASE contact the merge team and let us know what you think might be a problem and how you think the problem can be fixed, so that we can review your solution and make sure it does not cause conflicts elsewhere in the code.

In this case, you are absolutely correct with your changes to current-projects-check.js. Thank you for again for a great job!

@t-will-gillis t-will-gillis merged commit a735228 into hackforla:gh-pages Jul 27, 2023
@yffu
Copy link
Contributor Author

yffu commented Jul 27, 2023

Hey @yffu - Awesome job on your first issue! Your branches are correct, you linked the original issue, you explained the whats and the whys, and you provided the visuals of the before and after changes.

Bonus points for noticing the issue with current-projects-check.js. It is great and we definitely appreciate that you noticed the problem. If you see something like this in the future, however, PLEASE contact the merge team and let us know what you think might be a problem and how you think the problem can be fixed, so that we can review your solution and make sure it does not cause conflicts elsewhere in the code.

In this case, you are absolutely correct with your changes to current-projects-check.js. Thank you for again for a great job!

Thank you @t-will-gillis for the review and that by @steven-positive-tran. It set my mind at ease about the changes in current-project-checks since it was outside the initial issue description and I wasn't too sure about the different /projects and /projects-check pages... I'll definitely check with the merge team on the hfla-site slack channel about something like this in the future. Thanks again for the review and directions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for open-community-survey.md

3 participants