Skip to content

Refactor Tools data for design-systems.md#5097

Merged
adrianang merged 1 commit intohackforla:gh-pagesfrom
davidwiese:4802-refactor-tools-data-for-design-systemsmd
Jul 29, 2023
Merged

Refactor Tools data for design-systems.md#5097
adrianang merged 1 commit intohackforla:gh-pagesfrom
davidwiese:4802-refactor-tools-data-for-design-systemsmd

Conversation

@davidwiese
Copy link
Member

@davidwiese davidwiese commented Jul 26, 2023

Fixes #4802

What changes did you make?

  • Refactored tools data in design-systems.md from string to list.

Why did you make the changes (we will use this info to test)?

  • The filter menu will ultimately be revised to include a dropdown for "Tools", so that we can see where we might need to move project values from tools to technologies, and vice versa. In order for the filter to work properly, we need to refactor the tools data in the .md file from a string to a list.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b davidwiese-4802-refactor-tools-data-for-design-systemsmd gh-pages
git pull https://github.com/davidwiese/website.git 4802-refactor-tools-data-for-design-systemsmd

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 26, 2023
@StephenTheDev1001 StephenTheDev1001 self-requested a review July 27, 2023 01:46
Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to the correct issue and the md file has been updated correctly. I tested the changes in the browser and they work as expected. One minor suggestion for future pull requests: please put the issue number to the end of the branch name. This helps to keep track of the branches and their corresponding issues. Other than that, great work on your first issue!

@LRenDO LRenDO self-requested a review July 27, 2023 06:26
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidwiese! Nice work! This looks great!

  • Branching was done correctly (great recommendation on the issue number placement @StephenTheDev1001)
  • The changes made were correct and it works correctly on the site
  • No additional changes were made
  • The what and the why were included in the pull request

Great job! Thanks for taking the time to contribute to the site!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidwiese — the branching looks good and is set up correctly, the corresponding issue is linked, and the requested change of refactoring the Tools from a string into a list for the Design Systems project has been made exactly as requested. When testing your branch on my local machine via Docker, the Design Systems project page looks the same, as expected.

Thank you for taking up and completing this issue! 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for design-systems.md

4 participants