Refactor Tools data for design-systems.md#5097
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
StephenTheDev1001
left a comment
There was a problem hiding this comment.
Linked to the correct issue and the md file has been updated correctly. I tested the changes in the browser and they work as expected. One minor suggestion for future pull requests: please put the issue number to the end of the branch name. This helps to keep track of the branches and their corresponding issues. Other than that, great work on your first issue!
LRenDO
left a comment
There was a problem hiding this comment.
Hi @davidwiese! Nice work! This looks great!
- Branching was done correctly (great recommendation on the issue number placement @StephenTheDev1001)
- The changes made were correct and it works correctly on the site
- No additional changes were made
- The what and the why were included in the pull request
Great job! Thanks for taking the time to contribute to the site!
adrianang
left a comment
There was a problem hiding this comment.
Hi @davidwiese — the branching looks good and is set up correctly, the corresponding issue is linked, and the requested change of refactoring the Tools from a string into a list for the Design Systems project has been made exactly as requested. When testing your branch on my local machine via Docker, the Design Systems project page looks the same, as expected.
Thank you for taking up and completing this issue! 🙌🏼
Fixes #4802
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.