Skip to content

Updated tools data for Green Earth OS from string to list#5108

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
tiffchannn:refactor-tools-data-green-earth-4806
Jul 30, 2023
Merged

Updated tools data for Green Earth OS from string to list#5108
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
tiffchannn:refactor-tools-data-green-earth-4806

Conversation

@tiffchannn
Copy link
Contributor

Fixes #4806

What changes did you make?

  • Changed the tools data from a string to a list

Why did you make the changes (we will use this info to test)?

  • Changing the data shape is necessary since the projects-check page had a revision for the filter menu. Without the change, the filter will not work properly.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshot 2023-07-28 at 11 12 19 AM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b tiffchannn-refactor-tools-data-green-earth-4806 gh-pages
git pull https://github.com/tiffchannn/website.git refactor-tools-data-green-earth-4806

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 28, 2023
Copy link
Member

@DorianDeptuch DorianDeptuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tiffany,

I tested this in a local environment and everything works as it should. Your code formatter seems to have gotten rid of unnecessary whitespace as well. Everything looks good to me, great job!

@t-will-gillis t-will-gillis self-requested a review July 30, 2023 16:16
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @tiffchannn Great job on your first issue! Your to / from branches look good, you referenced the original issue number, you explained the whats and the whys of the issue, and you provided a screenshot from localhost:4000 which likely is an 'after' visual? In this specific issue, there won't be a visual change between before and after, but for the future please remember to show both.

Thanks for working on this issue!

@t-will-gillis t-will-gillis merged commit 9702bea into hackforla:gh-pages Jul 30, 2023
@tiffchannn tiffchannn deleted the refactor-tools-data-green-earth-4806 branch July 31, 2023 17:42
awellsbiz pushed a commit to awellsbiz/website that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for green-earth-os.md

3 participants