Refactor Tools data for ems-triage-tracker.md#5111
Refactor Tools data for ems-triage-tracker.md#5111t-will-gillis merged 1 commit intohackforla:gh-pagesfrom ivan20203:refacter-tools-data-emstriage-4803
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
DorianDeptuch
left a comment
There was a problem hiding this comment.
Hi Ivan,
I tested this in my local environment and the site seems to be working perfectly. Everything looks good to me, great job!
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @ivan20203 Good job! Your to/from branches are correct and you are linking to the original issue. Thanks for including the screenshots and the "What changes did you make?" and "Why did you make the changes?"
For the "What changes" and "Why" section, the intent is that you talk about the specifics of the changes and the reasons for doing so. This does not need to be elaborate and you can usually get an idea of what to write from the original issue. E.g. to answer the first question: "Refactored the tools data on ems-triage-tracker.md from a string to a list" and to answer the second: "This was done so that we can add a dropdown filter on the 'Projects Check' page to compare tools and technologies."
Thanks for working on this!
|
Changed answer for: What changes did you make? Changed answer for: Why did you make the changes (we will use this info to test)? |

Fixes #4803
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied