Skip to content

Refactor Tools data for ems-triage-tracker.md#5111

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ivan20203:refacter-tools-data-emstriage-4803
Jul 30, 2023
Merged

Refactor Tools data for ems-triage-tracker.md#5111
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ivan20203:refacter-tools-data-emstriage-4803

Conversation

@ivan20203
Copy link
Member

@ivan20203 ivan20203 commented Jul 29, 2023

Fixes #4803

What changes did you make?

  • refactored the tools data in the .md file from a string to a list.

Why did you make the changes (we will use this info to test)?

  • This refactoring was necessary to enable the addition of a dropdown filter on the 'Projects Check' page. The new filter will allow us to effectively compare and manage project values between 'tools' and 'technologies'.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-07-28 at 16 54 11
Visuals after changes are applied Screenshot 2023-07-28 at 16 54 28

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ivan20203-refacter-tools-data-emstriage-4803 gh-pages
git pull https://github.com/ivan20203/website.git refacter-tools-data-emstriage-4803

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 29, 2023
@DorianDeptuch DorianDeptuch self-requested a review July 29, 2023 01:55
Copy link
Member

@DorianDeptuch DorianDeptuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ivan,

I tested this in my local environment and the site seems to be working perfectly. Everything looks good to me, great job!

@t-will-gillis t-will-gillis self-requested a review July 30, 2023 16:29
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ivan20203 Good job! Your to/from branches are correct and you are linking to the original issue. Thanks for including the screenshots and the "What changes did you make?" and "Why did you make the changes?"

For the "What changes" and "Why" section, the intent is that you talk about the specifics of the changes and the reasons for doing so. This does not need to be elaborate and you can usually get an idea of what to write from the original issue. E.g. to answer the first question: "Refactored the tools data on ems-triage-tracker.md from a string to a list" and to answer the second: "This was done so that we can add a dropdown filter on the 'Projects Check' page to compare tools and technologies."

Thanks for working on this!

@ivan20203
Copy link
Member Author

Changed answer for: What changes did you make?
to: refactored the tools data in the .md file from a string to a list.

Changed answer for: Why did you make the changes (we will use this info to test)?
to:This refactoring was necessary to enable the addition of a dropdown filter on the 'Projects Check' page. The new filter will allow us to effectively compare and manage project values between 'tools' and 'technologies'.

@t-will-gillis
Copy link
Member

Thanks for making the changes to the description! Everything looks great.

For future reference after you make requested changes, you can re-request reviews by clicking the running arrows next to reviewers names so that the reviewers can approve the new changes:
Screenshot 2023-07-30 114402

@t-will-gillis t-will-gillis merged commit f025a32 into hackforla:gh-pages Jul 30, 2023
awellsbiz pushed a commit to awellsbiz/website that referenced this pull request Jul 31, 2023
@ivan20203 ivan20203 deleted the refacter-tools-data-emstriage-4803 branch August 2, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for ems-triage-tracker.md

3 participants