Refactor engage.md tools data from string to list#5122
Refactor engage.md tools data from string to list#5122adrianang merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Mon-Fri 4pm-7pm |
ldietz08
left a comment
There was a problem hiding this comment.
The pull request was done in the correct branch and you linked to the issue. As requested, the tools data was refactored from a string to a list. Well done!
|
ETA: EOD 8/4 |
kwangric
left a comment
There was a problem hiding this comment.
Branches are set up correctly. The requested changes were made to the code and everything still looks good in Docker. The pull request also contains a description of what changes were made and why. Well done!
There was a problem hiding this comment.
Hi @a-t-klein — the branching is set up correctly, the corresponding issue is linked, the requested change has been made exactly as asked (refactor Tools into a list for Engage), and the change didn't visually or functionally affect the Engage project views for its page and card layouts when testing your branch on my local environment through Docker. The What/Why sections in your PR were also well-written.
Thanks for taking up this issue! 🙌🏼
Fixes #4804
What changes did you make?
Why did you make the changes (we will use this info to test)?