Skip to content

4799 refactor tools list for brigade#5124

Merged
roslynwythe merged 2 commits intohackforla:gh-pagesfrom
PoppaRainmaker:4799-Refactor-tools-list-for-brigade
Aug 16, 2023
Merged

4799 refactor tools list for brigade#5124
roslynwythe merged 2 commits intohackforla:gh-pagesfrom
PoppaRainmaker:4799-Refactor-tools-list-for-brigade

Conversation

@PoppaRainmaker
Copy link
Member

@PoppaRainmaker PoppaRainmaker commented Aug 1, 2023

Fixes #4799

What changes did you make?

  • changed tools list for the brigade organizers playbook

Why did you make the changes (we will use this info to test)?

  • tools list needed to be converted to a list for searching/filtering purposes

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes expected, only functional changes expected when filter feature is implemented

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b PoppaRainmaker-4799-Refactor-tools-list-for-brigade gh-pages
git pull https://github.com/PoppaRainmaker/HfLAwebsite.git 4799-Refactor-tools-list-for-brigade

@PoppaRainmaker PoppaRainmaker linked an issue Aug 1, 2023 that may be closed by this pull request
5 tasks
@roslynwythe roslynwythe self-requested a review August 2, 2023 19:24
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PoppaRainmaker please update the first line of the PR to read:

Fixes #4799

Without that information, our GHA scripts are not able to link the PR to an issue, which causes a number of problems with our automation, and also makes it more difficult for PR reviewers who need to refer to the original issue. Thanks!

@LRenDO
Copy link
Member

LRenDO commented Aug 9, 2023

Hi @ronaldpaek and @mademarc! When you have a minute, please add your availability and eta. Thanks!

@ronaldpaek
Copy link
Member

Hi team I will review this PR on Friday, August 11th before EOD.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) status: To Update! No update has been provided P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Aug 10, 2023
Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made look correct to me, I checked file and the local instance no issues there. Thank you for all your hard work as services, great job!

@mademarc
Copy link
Member

Review ETA: 8/11/2023
Availability: 5:16PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PoppaRainmaker the screenshots a 404 error on the image if it is possible to fix that to see what changes that you have done for proper reviewing that said the code changes on line 93 look fine and @LRenDO the ETA and Availability is done.

@PoppaRainmaker
Copy link
Member Author

PoppaRainmaker commented Aug 12, 2023

Hi @PoppaRainmaker please update the first line of the PR to read:

Fixes #4799

Without that information, our GHA scripts are not able to link the PR to an issue, which causes a number of problems with our automation, and also makes it more difficult for PR reviewers who need to refer to the original issue. Thanks!

Thanks @roslynwythe - I believe I added the issue id in the description as you requested, please confirm when you get a chance.

@PoppaRainmaker
Copy link
Member Author

Hey @PoppaRainmaker the screenshots a 404 error on the image if it is possible to fix that to see what changes that you have done for proper reviewing that said the code changes on line 93 look fine and @LRenDO the ETA and Availability is done.

Thanks @mademarc - I don’t believe I added a screenshot, unless I’m mistaken there shouldn’t be any difference in terms of the page display after the changes. I can add a before and after though to memorialize this if it’s standard procedure.

@kwangric
Copy link
Member

Hey @PoppaRainmaker! If you've made the requested changes, you can re-request reviews from the assigned reviewers so they know when to take a look at your PR again.
review-2

Also if nothing changed visually on the website, you can remove the screenshots and just write a message in your PR that there weren't any visual changes.

@github-actions github-actions bot removed the status: To Update! No update has been provided label Aug 15, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PoppaRainmaker You've made the correct code change, setup the branches correctly, described your work, and linked your PR to the isssue. The change checks out perfectly in the browser. Great job on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for brigade-organizers-playbook.md

6 participants