4799 refactor tools list for brigade#5124
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
roslynwythe
left a comment
There was a problem hiding this comment.
Hi @PoppaRainmaker please update the first line of the PR to read:
Fixes #4799
Without that information, our GHA scripts are not able to link the PR to an issue, which causes a number of problems with our automation, and also makes it more difficult for PR reviewers who need to refer to the original issue. Thanks!
|
Hi @ronaldpaek and @mademarc! When you have a minute, please add your availability and eta. Thanks! |
|
Hi team I will review this PR on Friday, August 11th before EOD. |
ronaldpaek
left a comment
There was a problem hiding this comment.
The changes you made look correct to me, I checked file and the local instance no issues there. Thank you for all your hard work as services, great job!
|
Review ETA: 8/11/2023 |
mademarc
left a comment
There was a problem hiding this comment.
Hey @PoppaRainmaker the screenshots a 404 error on the image if it is possible to fix that to see what changes that you have done for proper reviewing that said the code changes on line 93 look fine and @LRenDO the ETA and Availability is done.
Thanks @roslynwythe - I believe I added the issue id in the description as you requested, please confirm when you get a chance. |
Thanks @mademarc - I don’t believe I added a screenshot, unless I’m mistaken there shouldn’t be any difference in terms of the page display after the changes. I can add a before and after though to memorialize this if it’s standard procedure. |
|
Hey @PoppaRainmaker! If you've made the requested changes, you can re-request reviews from the assigned reviewers so they know when to take a look at your PR again. Also if nothing changed visually on the website, you can remove the screenshots and just write a message in your PR that there weren't any visual changes. |
roslynwythe
left a comment
There was a problem hiding this comment.
Thank you @PoppaRainmaker You've made the correct code change, setup the branches correctly, described your work, and linked your PR to the isssue. The change checks out perfectly in the browser. Great job on this issue.

Fixes #4799
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes expected, only functional changes expected when filter feature is implemented