Skip to content

Refactor Tools data for tech-work-experience.md#5128

Merged
adrianang merged 1 commit intohackforla:gh-pagesfrom
ziniwang:refactor-tools-data-techworkexperience-4913
Aug 5, 2023
Merged

Refactor Tools data for tech-work-experience.md#5128
adrianang merged 1 commit intohackforla:gh-pagesfrom
ziniwang:refactor-tools-data-techworkexperience-4913

Conversation

@ziniwang
Copy link
Member

@ziniwang ziniwang commented Aug 1, 2023

Fixes #4913

What changes did you make?

  • Refactor the tools data in the tech-work-experience.md file from a string to a list

Why did you make the changes (we will use this info to test)?

  • To include a dropdown for 'Tools' for the filter menu on the 'projects-check' page

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ziniwang-refactor-tools-data-techworkexperience-4913 gh-pages
git pull https://github.com/ziniwang/website.git refactor-tools-data-techworkexperience-4913

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Aug 1, 2023
@yujioshiro yujioshiro self-requested a review August 2, 2023 05:40
@yujioshiro
Copy link
Member

Review ETA: 8/2/23 EOD
Availability: 8/2 8pm-10pm

@wongstephen wongstephen self-requested a review August 2, 2023 18:33
@wongstephen
Copy link
Member

Availability 8/2
ETA EOD

@wongstephen
Copy link
Member

wongstephen commented Aug 2, 2023

Hi @ziniwang,

Issue is linked correctly, the naming convention of the branch is easy to follow, changes to the issue are documented and the code fix looks correct I can confirm that the site works and has the correct information on it when it is run in my local environment. Great work!

Copy link
Member

@wongstephen wongstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your first issue pull request!

Copy link
Member

@yujioshiro yujioshiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @ziniwang!

The branches are set up correctly, the changes reflect what the issue asks for, and the description is accurate.

While there are no visual changes to the site, because the issue asks that you confirm the tools still renders correctly, I think it would be good to upload images of the list being rendered correctly the next time.

I pulled @ziniwang's branch and confirmed that the list renders correctly both on the projects page as well as the Tech Work Experience page.

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ziniwang — the branching is set up correctly, the corresponding issue is linked, and the requested change of refactoring the Tools data for Tech Work Experience has been made exactly as requested in the linked issue. In testing your branch in my local environment through Docker, the change you made did not visually (except for title-casing 1Password, which seems to be more accurate anyway) or functionally affect the project in its various views (project pages and cards on mobile, tablet, and desktop).

Thank you for taking up this issue! 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tools data for tech-work-experience.md

4 participants