Food oasis .md file refactored#5133
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Aug 4, 10am-12pm pst |
|
Availability: 6-12pm pst |
steven-positive-tran
left a comment
There was a problem hiding this comment.
Branches look from your fork to the main gh-pages, works on my device, and code changes seem in line with the issues that need to be addressed.
Looks good and thank you for taking up this issue.
evanhesketh
left a comment
There was a problem hiding this comment.
As noted by the previous reviewer, branching is done correctly, issue is linked, the changes appear correctly in the browser, and the changes address the issue.
Please consider adding before/after screenshots of the website to your pull request to help reviewers visualize the changes you have made. Otherwise, great work!
|
Sounds good! Thanks for the review |
adrianang
left a comment
There was a problem hiding this comment.
Hi @awellsbiz — the branching is set up correctly, the corresponding issue has been linked to, and the requested change of refactoring the Tools into a list for Food Oasis has been made exactly as asked in the issue. In testing your branch on my local environment through Docker, the views for Food Oasis do not appear to be visually or functionally affected, as expected.
Good job figuring out the workflow from your previous PR; this PR is looking a lot cleaner in the commit history now! One thing that I would say is that your PR submissions should either include a photo if there is a visual change, or not have the image section at all, instead of having broken photo links; something to keep in mind for your next PR(s).
Thank you for taking up this issue! 🙌🏼
|
Hey @adrianang,
Noted.
Thanks,
AW
…On Sat, Aug 5, 2023 at 6:37 PM Adrian Ang ***@***.***> wrote:
Merged #5133 <#5133> into
gh-pages.
—
Reply to this email directly, view it on GitHub
<#5133 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6IF6HVPVOYLXZEJCRZ46UDXT3YODANCNFSM6AAAAAA3CGHV6M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fixes #4805
What changes did you make?
food-oasis.mdfile from a string to listWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied