Skip to content

Refactored HTML on the about page sponsors card#5327

Merged
Adastros merged 1 commit intohackforla:gh-pagesfrom
allison-truhlar:refactor-html-about-card-sponsors-5288
Aug 29, 2023
Merged

Refactored HTML on the about page sponsors card#5327
Adastros merged 1 commit intohackforla:gh-pagesfrom
allison-truhlar:refactor-html-about-card-sponsors-5288

Conversation

@allison-truhlar
Copy link
Member

@allison-truhlar allison-truhlar commented Aug 28, 2023

Fixes #5288

What changes did you make?

  • Updated HTML tag to change single quotes around class names to double quotes

Why did you make the changes (we will use this info to test)?

  • To resolve a linter error: "Value of attribute [class] must be in double quotes"

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes caused by refactoring HTML for class attribute.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b allison-truhlar-refactor-html-about-card-sponsors-5288 gh-pages
git pull https://github.com/allison-truhlar/website.git refactor-html-about-card-sponsors-5288

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 28, 2023
@Jmmcclo2023 Jmmcclo2023 self-assigned this Aug 28, 2023
@Jmmcclo2023
Copy link
Member

Availability: 4-6pm EDT Daily
ETA: 8/30

@evanhesketh evanhesketh self-requested a review August 28, 2023 21:14
@evanhesketh
Copy link
Member

Availability: 9-10am EDT Tuesday, Wednesday
ETA: EOD 08/28

Copy link
Member

@evanhesketh evanhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branching is done correctly, the issue is linked, and changes made address the issue. There were no visual changes to the website.

One minor detail that was momentarily confusing: your comment on the PR regarding what changes were made suggests you changed double quotes to single quotes, when what you did was the opposite (correctly).

Otherwise, looks great!

@Jmmcclo2023 Jmmcclo2023 removed their assignment Aug 28, 2023
@Jmmcclo2023 Jmmcclo2023 self-requested a review August 28, 2023 22:05
Copy link
Member

@Jmmcclo2023 Jmmcclo2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job completing the issue!

As Evan stated above, you might need to edit the pull request to correctly state the changes of your issue to match what you actually did.
Otherwise, everything looks good! This post contains the correct branch and the correctly linked issue, no screenshots since there are no visual changes, all changes are done in the correct file, all applicable action items are completed, and the source code looks good!

@allison-truhlar
Copy link
Member Author

Thanks, @evanhesketh and @Jmmcclo2023 for catching the error in my opening comment! I have edited it to correctly reflect the change from single quotes to double quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _includes/about-page/about-card-sponsors.html

4 participants