Refactored HTML on the about page sponsors card#5327
Conversation
…instead of single quotes around class names
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 4-6pm EDT Daily |
|
Availability: 9-10am EDT Tuesday, Wednesday |
evanhesketh
left a comment
There was a problem hiding this comment.
Branching is done correctly, the issue is linked, and changes made address the issue. There were no visual changes to the website.
One minor detail that was momentarily confusing: your comment on the PR regarding what changes were made suggests you changed double quotes to single quotes, when what you did was the opposite (correctly).
Otherwise, looks great!
Jmmcclo2023
left a comment
There was a problem hiding this comment.
Great job completing the issue!
As Evan stated above, you might need to edit the pull request to correctly state the changes of your issue to match what you actually did.
Otherwise, everything looks good! This post contains the correct branch and the correctly linked issue, no screenshots since there are no visual changes, all changes are done in the correct file, all applicable action items are completed, and the source code looks good!
|
Thanks, @evanhesketh and @Jmmcclo2023 for catching the error in my opening comment! I have edited it to correctly reflect the change from single quotes to double quotes. |
Fixes #5288
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes caused by refactoring HTML for class attribute.