Skip to content

Refactor HTML to resolve linter error#5343

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ortegaa32:refactor-html-5285
Sep 1, 2023
Merged

Refactor HTML to resolve linter error#5343
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ortegaa32:refactor-html-5285

Conversation

@ortegaa32
Copy link
Member

Fixes #5285

What changes did you make?

  • Switched single quotes to double quotes in HTML div tag

Why did you make the changes (we will use this info to test)?

  • To resolve the linter error "Value of attribute [class] must be in double quotes"

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ortegaa32-refactor-html-5285 gh-pages
git pull https://github.com/ortegaa32/website.git refactor-html-5285

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 29, 2023
@tesiahwang tesiahwang self-requested a review August 30, 2023 04:12
@tesiahwang
Copy link
Member

Review ETA: 8/30/2023
Availability: flexible

Copy link
Member

@tesiahwang tesiahwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ortegaa32 - you are attempting to merge your commit into the correct base branch, are linking the corresponding issue with the proper PR formatting, and your change is applicable & clean!

@roslynwythe roslynwythe added this to the x. Technical debt milestone Aug 30, 2023
@celinalou92
Copy link
Member

Review ETA: 8/31/2023
Availability: flexible

@mademarc
Copy link
Member

mademarc commented Sep 1, 2023

Review ETA: 8/31/2023
Availability: 7:08PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ortegaa32 I like how readable your code is on line 1 as the small change was made also Great job!

@t-will-gillis t-will-gillis self-requested a review September 1, 2023 16:01
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ortegaa32 - Great job on your first issue! Your branches look good, you are linked to the original issue, you have included descriptions of what you did and why, and your code is clean. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _includes/about-page/about-card-donations.html

6 participants