Skip to content

added the missing span tag #5368#5457

Merged
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
kiran98118:added-span-tag
Sep 17, 2023
Merged

added the missing span tag #5368#5457
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
kiran98118:added-span-tag

Conversation

@kiran98118
Copy link
Contributor

@kiran98118 kiran98118 commented Sep 8, 2023 •
edited
Loading

Fixes #5368

What changes did you make?

  • added the missing span tag

Why did you make the changes (we will use this info to test)?

  • the span tag is missing in one section which makes code inconsistent

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kiran98118-added-span-tag gh-pages
git pull https://github.com/kiran98118/website.git added-span-tag

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 8, 2023
@Vinny02
Copy link
Contributor

Vinny02 commented Sep 8, 2023

ETA: Sep 8 Noon
Availability: 6-12PM

@Vinny02 Vinny02 self-requested a review September 8, 2023 11:02
Vinny02
Vinny02 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Vinny02 Vinny02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @kiran98118 ! I can confirm you have merged to and from the correct branches, that the changes are correct, and the issue is successfully linked. Thank you for contributing!

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 9, 2023 •
edited
Loading

Hello @kiran98118 - please add a note to PR #5396 stating that this PR is a replacement, then close 5396. Also, I will add @lateral-neck-stretch to the reviewers since they reviewed the first iteration.

@antho-zng
Copy link
Member

antho-zng commented Sep 13, 2023

Availability: 9–5pm ET
ETA: Sept 13 EOD (by 5pm ET)

antho-zng
antho-zng approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@antho-zng antho-zng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kiran98118! The changes address the original issue, and the page looks good on my locally hosted version!

@drakenguyen4000 drakenguyen4000 merged commit 4335d28 into hackforla:gh-pages Sep 17, 2023
@t-will-gillis t-will-gillis mentioned this pull request Sep 17, 2023
Closed
This was referenced Aug 10, 2025
Closed
Closed
Closed
@t-will-gillis t-will-gillis mentioned this pull request Aug 22, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@antho-zng antho-zng antho-zng approved these changes

@Vinny02 Vinny02 Vinny02 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Diversity

5 participants

@kiran98118 @Vinny02 @t-will-gillis @antho-zng @drakenguyen4000