Skip to content

Added span tag to learning section#5564

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
soleilherring:refactor-html-about-card-platform-5367
Sep 27, 2023
Merged

Added span tag to learning section#5564
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
soleilherring:refactor-html-about-card-platform-5367

Conversation

@soleilherring
Copy link
Member

@soleilherring soleilherring commented Sep 21, 2023

Fixes #5367

What changes did you make?

  • added span tag to the learning section of the about section

Why did you make the changes (we will use this info to test)?

  • We want to update an HTML tag to resolve the linter error "Tag must be paired; missing "

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b soleilherring-refactor-html-about-card-platform-5367 gh-pages
git pull https://github.com/soleilherring/website.git refactor-html-about-card-platform-5367

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 21, 2023
@one2code one2code self-requested a review September 21, 2023 03:54
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job on making the requested changes, and merging into the correct branch on your 1st commit. For future PR submissions, it's ok to remove unused bullet points and skip the visual if no visual changes are made.

@one2code one2code self-requested a review September 21, 2023 03:59
@t-will-gillis t-will-gillis self-requested a review September 24, 2023 16:29
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @soleilherring Your PR looks great! Your branches from/to are good, you are linked back to the original issue, you are briefly describing what you did and why, and your edits change only what needs to be changed. As @one2code noted, on the description of what you did and why, could you delete the extra bullet points? Also, for the "Screenshots" section, since there are no visual changes here you can delete the "Visuals before/ after" dropdowns and replace with a note such as "No visual changes to the website".

Otherwise, this is good to go- thanks for contributing!

@soleilherring
Copy link
Member Author

@t-will-gillis I deleted extra bullet points and removed the screenshot. Thank you!

@t-will-gillis t-will-gillis self-requested a review September 27, 2023 19:45
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @soleilherring Thanks for making the changes- looks perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Learning

3 participants