Added span tag to learning section#5564
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
one2code
left a comment
There was a problem hiding this comment.
Excellent job on making the requested changes, and merging into the correct branch on your 1st commit. For future PR submissions, it's ok to remove unused bullet points and skip the visual if no visual changes are made.
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @soleilherring Your PR looks great! Your branches from/to are good, you are linked back to the original issue, you are briefly describing what you did and why, and your edits change only what needs to be changed. As @one2code noted, on the description of what you did and why, could you delete the extra bullet points? Also, for the "Screenshots" section, since there are no visual changes here you can delete the "Visuals before/ after" dropdowns and replace with a note such as "No visual changes to the website".
Otherwise, this is good to go- thanks for contributing!
|
@t-will-gillis I deleted extra bullet points and removed the screenshot. Thank you! |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @soleilherring Thanks for making the changes- looks perfect.
Fixes #5367
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)