Skip to content

Add GitHub handle 100automations kim audrey 5508#5576

Merged
kwangric merged 2 commits intohackforla:gh-pagesfrom
tonyvang:add-github-handle-100automations-kim-audrey-5508
Sep 29, 2023
Merged

Add GitHub handle 100automations kim audrey 5508#5576
kwangric merged 2 commits intohackforla:gh-pagesfrom
tonyvang:add-github-handle-100automations-kim-audrey-5508

Conversation

@tonyvang
Copy link
Contributor

Fixes #5508

What changes did you make?

  • In 100 Automations project page, added new variable github-handle below -name: Audrey Kim, w/o assignment, nested like other variables assoc. w/Kim eg role.

Why did you make the changes (we will use this info to test)?

  • To hold the github handle for this member o/100 Automations leadership team
  • To prepare for the eventual replacement of the github and picture variables
  • In re: issue 5508

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Added variable without assignment; no visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b tonyvang-add-github-handle-100automations-kim-audrey-5508 gh-pages
git pull https://github.com/tonyvang/website.git add-github-handle-100automations-kim-audrey-5508

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 24, 2023
@ajb176 ajb176 self-requested a review September 24, 2023 13:54
@ajb176
Copy link
Member

ajb176 commented Sep 24, 2023

Review ETA: 9/25 EOD
Availability: 5-9am

@roslynwythe roslynwythe requested a review from ha-bach September 24, 2023 17:11
@ha-bach
Copy link
Member

ha-bach commented Sep 24, 2023

Reviewing this PR
ETA: should be end of week
Availability: weekends

@ajb176
Copy link
Member

ajb176 commented Sep 25, 2023

Nice catch that the original change disrupted the webpage, and nice work showing your blocker here. I'm seeing that issue as well, and I also see that the change you proposed doesn't cause any disruption.

I think the template for these issues may need to be slightly changed, I'll check on that quickly before approving/requesting changes. But you definitely haven't done anything wrong.

Nice work!

@roslynwythe
Copy link
Member

@ajb176 @muninnhugin @tonyvang there is an error in this issue and it will be updated shortly. In the meantime do not review or merge. Thank you

@roslynwythe roslynwythe self-requested a review September 27, 2023 02:29
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tonyvang for excellent work on this issue. Your testing and analysis were 100% correct and your code change is correct and clean. You created a PR with correct branches and a useful description of your work. Thank you for your contribution to Hack for LA!

@tonyvang
Copy link
Contributor Author

Thanks @ajb176 & @roslynwythe for the reviews; I wasn't sure about my changes at first, but I hope this helps other devs working on these refactoring issues.

@kwangric kwangric merged commit 7814a7d into hackforla:gh-pages Sep 29, 2023
@tonyvang tonyvang deleted the add-github-handle-100automations-kim-audrey-5508 branch September 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle for member Audrey Kim in 100-automations.md

5 participants