Add GitHub handle 100automations kim audrey 5508#5576
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 9/25 EOD |
|
Reviewing this PR |
|
Nice catch that the original change disrupted the webpage, and nice work showing your blocker here. I'm seeing that issue as well, and I also see that the change you proposed doesn't cause any disruption. I think the template for these issues may need to be slightly changed, I'll check on that quickly before approving/requesting changes. But you definitely haven't done anything wrong. Nice work! |
roslynwythe
left a comment
There was a problem hiding this comment.
Thank you @tonyvang for excellent work on this issue. Your testing and analysis were 100% correct and your code change is correct and clean. You created a PR with correct branches and a useful description of your work. Thank you for your contribution to Hack for LA!
|
Thanks @ajb176 & @roslynwythe for the reviews; I wasn't sure about my changes at first, but I hope this helps other devs working on these refactoring issues. |
Fixes #5508
What changes did you make?
github-handlebelow-name: Audrey Kim, w/o assignment, nested like other variables assoc. w/Kim egrole.Why did you make the changes (we will use this info to test)?
githubandpicturevariablesScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Added variable without assignment; no visual changes to the website.