added github handle variable for olivia chiong#5583
added github handle variable for olivia chiong#5583drakenguyen4000 merged 2 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
ETA: 9/26/23 |
|
ETA: EOD 9/26/23 |
There was a problem hiding this comment.
- The new branch is properly going into the correct branch gh-pages. ✅
- Original issue was properly linked and referenced. ✅
- github-handle has been added into the file per request. ✅
Hey Crystal,
Great job on the edits, My only request is your comment in this pull request seem to have some messed up formatting, as well as the images in before and after change is not showing. If the issue you've fixed have no visual changes you can simply delete that section of the comment. I will check back again when the comment formatting has been fixed and will approve then.
Great job
*Edit:
I've just found out from a different issue where the github handle needs to be added that this addition will separate the div in the website into 2 and will create another card with Olivia's picture and blank name. I am in the process of finding out what the website team wants to do about this. But right now this change will cause the website no not display the correct info.
|
@crystallyyy @Jfong1218 @homeroochoa47 There is an error in this issue. It will be edited shortly. In the meantime please do not review or merge. Thank you |
roslynwythe
left a comment
roslynwythe
left a comment
There was a problem hiding this comment.
@crystallyyy Please see the updated issue and my comment in the issue. I apologize for the error!
|
Hello, I corrected the error the way the issue #5506 specifies and am hoping to get this pull request approved! Let me know if there's anything else I should do! @Jfong1218 @homeroochoa47 |
roslynwythe
left a comment
roslynwythe
left a comment
There was a problem hiding this comment.
Thank you @crystallyyy for updating the PR based on the corrected issue. The PR has the correct branches and is descriptive and in the browser the 100 automations webpage looks fine.
Jfong1218
left a comment
Jfong1218
left a comment
There was a problem hiding this comment.
Hello Crystal,
Great job! I see no problem with this PR and will be approving it with this review.
Thank you
5 participants
Fixes #5506
What changes did you make?
-I made sure not to use tab, and deleted the dash
Why did you make the changes (we will use this info to test)?
-good first issue
Screenshots of Proposed Changes Of The Website