Fix linting error on about page#5616
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
ajb176
left a comment
There was a problem hiding this comment.
- Makes changes as requested in the linked issue #5372
- Merges into the correct branch
- No visual changes to website
Looks good, nice work @romainyvernes
MattChau01
left a comment
There was a problem hiding this comment.
- The branch is going into the correct branch
gh-pages. ✅ - The original issue #5372 was properly referenced. ✅
- The specified instance of an
<div>tag was updated accordingly with the provided line of code. ✅
Great work @romainyvernes !
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @romainyvernes Great job- branches look good, you are linked to the original issue, you described what you did and why, you noted that there are no visual changes, and your edits only change what needs to be changed. As a suggestion for the next PR, for "Why did you make the changes...?" a good way to answer this question is to paraphrase the original issue. In this case, 'Added the span tag to address the linting error "Tag must be paired; missing " '
Thanks for you contribution!
Fixes #5372
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)