Skip to content

Fix linting error on about page#5616

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
romainyvernes:fix-linting-error-5372
Oct 1, 2023
Merged

Fix linting error on about page#5616
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
romainyvernes:fix-linting-error-5372

Conversation

@romainyvernes
Copy link
Member

@romainyvernes romainyvernes commented Sep 27, 2023

Fixes #5372

What changes did you make?

  • Added a closing span tag to the Scalability sub-card within the Platform card on the About page

Why did you make the changes (we will use this info to test)?

  • Caused a linting error

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b romainyvernes-fix-linting-error-5372 gh-pages
git pull https://github.com/romainyvernes/hackforlawebsite.git fix-linting-error-5372

@romainyvernes romainyvernes changed the title Fix linting error on about page #5372 Fix linting error on about page Sep 27, 2023
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 27, 2023
@MattChau01 MattChau01 self-requested a review September 28, 2023 05:00
@ajb176 ajb176 self-requested a review September 29, 2023 09:08
Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Makes changes as requested in the linked issue #5372
  • Merges into the correct branch
  • No visual changes to website

Looks good, nice work @romainyvernes

Copy link
Member

@MattChau01 MattChau01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The branch is going into the correct branch gh-pages. ✅
  • The original issue #5372 was properly referenced. ✅
  • The specified instance of an <div> tag was updated accordingly with the provided line of code. ✅

Great work @romainyvernes !

@t-will-gillis t-will-gillis self-requested a review October 1, 2023 15:22
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @romainyvernes Great job- branches look good, you are linked to the original issue, you described what you did and why, you noted that there are no visual changes, and your edits only change what needs to be changed. As a suggestion for the next PR, for "Why did you make the changes...?" a good way to answer this question is to paraphrase the original issue. In this case, 'Added the span tag to address the linting error "Tag must be paired; missing " '

Thanks for you contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Scalability

4 participants