Skip to content

Fix linting error on about page#5646

Merged
kwangric merged 1 commit intohackforla:gh-pagesfrom
romainyvernes:fix-linting-error-5366
Oct 4, 2023
Merged

Fix linting error on about page#5646
kwangric merged 1 commit intohackforla:gh-pagesfrom
romainyvernes:fix-linting-error-5366

Conversation

@romainyvernes
Copy link
Member

Fixes #5366

What changes did you make?

  • Added a span closing tag

Why did you make the changes (we will use this info to test)?

  • To resolve the linter error "Tag must be paired; missing "

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b romainyvernes-fix-linting-error-5366 gh-pages
git pull https://github.com/romainyvernes/hackforlawebsite.git fix-linting-error-5366

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 2, 2023
@kristinstockley kristinstockley self-requested a review October 2, 2023 20:46
@kristinstockley
Copy link
Contributor

Review ETA: By EOD 10/3
Availability: 10/2 and 10/3

@kezzaam kezzaam self-requested a review October 3, 2023 05:50
@kezzaam
Copy link
Member

kezzaam commented Oct 3, 2023

Review ETA: By EOD 10/5
Availability: 10/3 and 10/5

Copy link
Member

@kezzaam kezzaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @romainyvernes! Great job on this issue. I can confirm you have handled the changes as specified and not broken or added anything. Awesome! Thanks for an easy review :)

Copy link
Member

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Copy link
Contributor

@kristinstockley kristinstockley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @romainyvernes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Sustainability

5 participants