Skip to content

modified CONTRIBUTING.md#5658

Merged
adrianang merged 1 commit intohackforla:gh-pagesfrom
robertnjenga:issue-branch-5588
Oct 11, 2023
Merged

modified CONTRIBUTING.md#5658
adrianang merged 1 commit intohackforla:gh-pagesfrom
robertnjenga:issue-branch-5588

Conversation

@robertnjenga
Copy link
Member

@robertnjenga robertnjenga commented Oct 3, 2023

Fixes #5588

What changes did you make?

  • Replaced:
  1. Complexity: Good second issue
  • Self-assign an issue with the Complexity: Good second issue label.
  • Complete steps in 2.7 Working on an issue to create a solution for the issue
  • Complete steps in 3.1 How to make a pull request to get your solution reviewed by the website-merge team
  • Once your pull request is merged, you can work on your next issue.

Progress through issues with increasing complexity in the following order:

  1. Good first issue
  2. Good second issue
  3. Small
  4. Medium
  5. Large
  • With:
  1. Repeat Use front matter loader to import markdown content, start on switchin… #1 with a new good first issue

Progress through issues with increasing complexity in the following order:

  1. Good first issue (x2)
  2. Small
  3. Medium
  4. Large
  5. Extra Large

Why did you make the changes (we will use this info to test)?

  • to remove references to "good second issue" from CONTRIBUTING.md in order to avoid confusion, since we are no longer creating issues with the label `Complexity: good second issue'.

For Reviewers:

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes have been made.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b robertnjenga-issue-branch-5588 gh-pages
git pull https://github.com/robertnjenga/website.git issue-branch-5588

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Oct 3, 2023
@Thinking-Panda Thinking-Panda self-requested a review October 4, 2023 01:57
@Thinking-Panda
Copy link
Member

Availability: Weekdays
ETA: 10/4

@DorianDeptuch DorianDeptuch self-requested a review October 5, 2023 04:19
@DorianDeptuch
Copy link
Member

Availability: Weekday afternoons/evenings
ETA: EoD 10/5

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertnjenga nice work on this issue. Branches are setup correctly, code changes are as mentioned in the issue and clean. The changes are reflecting in the test link provided. Thank you!

Copy link
Member

@DorianDeptuch DorianDeptuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertnjenga ,

Thanks for taking up this issue. You correctly stated what changes were mad, why they were made, and you linked to the updated template on your forked repo. It was a little hard to read through the "What" and the "Why" sections at first due to the formatting. The correct changes were made in the template and everything else looks good. Great job!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertnjenga — good job with this issue so far! The branching is set up correctly, the corresponding issue is linked, the change of updating step 2 and the progression outlined in the CONTRIBUTING.md document has been made exactly as requested, and this change is reflected in your branch of the document.

Before I can merge this issue, there's just one change that should be made: can you remove the details and summary tags in the Screenshots section of your PR and instead state that no visual changes have been made? Doing this will help keep our documentation clean and easy to use (by indicating at a quick glance that there were no visual changes).

Once the PR has been correctly edited, I can merge this PR to the codebase; everything else is looking good so far!

@robertnjenga robertnjenga requested a review from adrianang October 9, 2023 14:41
Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertnjenga — thank you for making the edit in your PR! It looks good to me and everything else had stayed the same from the last review.

Thank you for taking up and completing this issue! 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "good second issue" from CONTRIBUTING.md Section 2.1

4 participants