Skip to content

resolve linter error in about-card-platform.html#5702

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
king-of-tiktok:resolve-linter-error-in-about-card-platform-html-to-fix-5318
Oct 15, 2023
Merged

resolve linter error in about-card-platform.html#5702
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
king-of-tiktok:resolve-linter-error-in-about-card-platform-html-to-fix-5318

Conversation

@jaasonw
Copy link
Member

@jaasonw jaasonw commented Oct 11, 2023

Fixes #5318

What changes did you make?

  • Replaced single quotes with double quotes in about-card-platform.html

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b king-of-tiktok-resolve-linter-error-in-about-card-platform-html-to-fix-5318 gh-pages
git pull https://github.com/king-of-tiktok/website.git resolve-linter-error-in-about-card-platform-html-to-fix-5318

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 11, 2023
@freaky4wrld
Copy link
Member

Availability: Thursday 12th October, Evening
ETA: Friday 13th October, EOD

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jaasonw

  • The merging branch is correct
  • You have made changes specified in the issue
  • The reason for making changes is clearly mentioned and issue is linked within it

Great work buddy......

@freaky4wrld freaky4wrld self-requested a review October 11, 2023 04:32
@t-will-gillis t-will-gillis merged commit a3918ba into hackforla:gh-pages Oct 15, 2023
ronaldpaek

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _includes/about-page/about-card-platform.html

4 participants