Add Missing Closing Tags in About Page#5732
Conversation
…d Agility sections
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: weekday |
Tomomi-K1
left a comment
There was a problem hiding this comment.
Hi @Sediqa-Fahimi, great job taking on this good first issue!🎇
I see that you used correct branches and have a linked issue and create the nicely formatted pull request.😊
One thing I need to point out is that you had fixed more than what was asked in the linked issue. I believe you were only supposed to update one line of code: <span> that wraps "Agility"
<div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/agility.svg" alt=""></span><span class="sub-head-text color-deeppink">Agility</div>
I saw this spreadsheet on the linked issue : HfLA-Website: HTML linter audit spreadsheet. From this, I see that the team is making one issue for one </span> tag needed to be added (not per page).
Please edit your code to undo changes you have made on line 7:
<div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/workforce-development.svg" alt=""></span><span class="sub-head-text color-dodgerblue">Workforce Development</span></div>
and line 17:
<div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/impact.svg" alt=""></span><span class="sub-head-text color-lightseagreen">Impact</span></div>
…refactor-html-missing-closing-tag-5370
|
Hi @Tomomi-K1 , |
Tomomi-K1
left a comment
There was a problem hiding this comment.
@Sediqa-Fahimi Thank you for undoing some of the changes you made to meet with the issue requirement. Great job!
|
@mademarc please provide an ETA for reviewing this PR. Thank you |
|
Review ETA: 10/19/2023 |
mademarc
left a comment
There was a problem hiding this comment.
Hey @Sediqa-Fahimi well done on the adding for line 52 on this issue and @roslynwythe the ETa is done already.
|
ETA: EOD 10/20 |
kwangric
left a comment
There was a problem hiding this comment.
Branches are set up correctly. The requested changes are made and the PR includes a description of the changes made and why. Great work @Sediqa-Fahimi!
Fixes #5370
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)
Refactoring HTML codes. No visual changes to the website.