Skip to content

Add Missing Closing Tags in About Page#5732

Merged
kwangric merged 3 commits intohackforla:gh-pagesfrom
fahimicodes:refactor-html-missing-closing-tag-5370
Oct 20, 2023
Merged

Add Missing Closing Tags in About Page#5732
kwangric merged 3 commits intohackforla:gh-pagesfrom
fahimicodes:refactor-html-missing-closing-tag-5370

Conversation

@fahimicodes
Copy link
Member

Fixes #5370

What changes did you make?

  • Added the missing closing tags in three sections on the About page.

Why did you make the changes (we will use this info to test)?

  • To remove linter errors caused by span tags that were not paired with closing tags.

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

Refactoring HTML codes. No visual changes to the website.

@fahimicodes fahimicodes self-assigned this Oct 17, 2023
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Sediqa-Fahimi-refactor-html-missing-closing-tag-5370 gh-pages
git pull https://github.com/Sediqa-Fahimi/website.git refactor-html-missing-closing-tag-5370

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 17, 2023
@Tomomi-K1 Tomomi-K1 self-requested a review October 17, 2023 23:54
@Tomomi-K1
Copy link
Member

Availability: weekday
ETA: 10/18

Copy link
Member

@Tomomi-K1 Tomomi-K1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sediqa-Fahimi, great job taking on this good first issue!🎇
I see that you used correct branches and have a linked issue and create the nicely formatted pull request.😊

One thing I need to point out is that you had fixed more than what was asked in the linked issue. I believe you were only supposed to update one line of code: <span> that wraps "Agility"

<div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/agility.svg" alt=""></span><span class="sub-head-text color-deeppink">Agility</div>

I saw this spreadsheet on the linked issue : HfLA-Website: HTML linter audit spreadsheet. From this, I see that the team is making one issue for one </span> tag needed to be added (not per page).

Please edit your code to undo changes you have made on line 7:

 <div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/workforce-development.svg" alt=""></span><span class="sub-head-text color-dodgerblue">Workforce Development</span></div>

and line 17:

 <div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/impact.svg" alt=""></span><span class="sub-head-text color-lightseagreen">Impact</span></div>

@fahimicodes fahimicodes requested a review from Tomomi-K1 October 18, 2023 23:15
@fahimicodes
Copy link
Member Author

Hi @Tomomi-K1 ,
Thank you for your comment. I made the suggested changes above for your review. Thanks!

Copy link
Member

@Tomomi-K1 Tomomi-K1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sediqa-Fahimi Thank you for undoing some of the changes you made to meet with the issue requirement. Great job!

@roslynwythe
Copy link
Member

@mademarc please provide an ETA for reviewing this PR. Thank you

@mademarc
Copy link
Member

Review ETA: 10/19/2023
Availability: 7:50PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sediqa-Fahimi well done on the adding for line 52 on this issue and @roslynwythe the ETa is done already.

@kwangric kwangric self-requested a review October 20, 2023 13:38
@kwangric
Copy link
Member

ETA: EOD 10/20
Availability: 7am-10am PDT

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The requested changes are made and the PR includes a description of the changes made and why. Great work @Sediqa-Fahimi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Agility

5 participants