Skip to content

Updated cspell.json by adding "Westside" #5618#5744

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
kevin31yu:westside-code-spell-checker-5618
Oct 22, 2023
Merged

Updated cspell.json by adding "Westside" #5618#5744
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
kevin31yu:westside-code-spell-checker-5618

Conversation

@kevin31yu
Copy link
Member

@kevin31yu kevin31yu commented Oct 20, 2023

Fixes #5618

What changes did you make?

  • Installed Code Spell Checker via VSCode
  • Created new branch and edited cspell.json, added "Westside" to the config file
  • Checked '_includes/events-page/our-locations-content.html' and no error message

Why did you make the changes (we will use this info to test)?

  • There was an error message "Unknown word" for the word "Westside"

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes

@kevin31yu kevin31yu self-assigned this Oct 20, 2023
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kevin31yu-westside-code-spell-checker-5618 gh-pages
git pull https://github.com/kevin31yu/website.git westside-code-spell-checker-5618

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Infrastructure For changes on site technical architecture size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Oct 20, 2023
@kevin31yu kevin31yu changed the title Fixed #5618 Updated cspell.json by adding "Westside" #5618 Oct 20, 2023
@freaky4wrld freaky4wrld self-requested a review October 21, 2023 04:09
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @kevin31yu , here are some changes that you can do

  • In the reason for changes made section you have to empty bullets, remove those( dashes )
  • In the visual changes remove the changes after and before section and instead mention No visual changes

Rest is cool, make these mentioned changes so that I can approve the PR.

@kevin31yu
Copy link
Member Author

Hey there @kevin31yu , here are some changes that you can do

  • In the reason for changes made section you have to empty bullets, remove those( dashes )
  • In the visual changes remove the changes after and before section and instead mention No visual changes

Rest is cool, make these mentioned changes so that I can approve the PR.

Hi, I have made the corrections. Thanks for your time.

@freaky4wrld freaky4wrld self-requested a review October 22, 2023 13:35
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kevin31yu great work there,

  • the merging branch is correct
  • the reason for changes is correctly mentioned
  • the issue is correctly linked
  • the specified changes are done correctly

Keep up the good work

@t-will-gillis t-will-gillis self-requested a review October 22, 2023 15:44
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kevin31yu Great job! You have the correct branches from and to, you are linked to the original issue, you have explained what you did and why, you mention that there are no visual changes to the website, and your code edits changes only what needs to be changed.

Great job working with @freaky4wrld and congrats on your first PR!

@t-will-gillis t-will-gillis merged commit 5615477 into hackforla:gh-pages Oct 22, 2023
@kevin31yu kevin31yu deleted the westside-code-spell-checker-5618 branch October 22, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Infrastructure For changes on site technical architecture feature: spelling good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Westside" to list of words in Code Spell Checker configuration file

3 participants