Skip to content

Add Code Spell Checker#5751

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
jackyuan1:add-code-spell-checker-4101
Oct 23, 2023
Merged

Add Code Spell Checker#5751
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
jackyuan1:add-code-spell-checker-4101

Conversation

@jackyuan1
Copy link
Member

Fixes #4101

What changes did you make?

  • Add code spell checker to local repo
  • Add instructions within CONTRIBUTING.md

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

Screenshot 2023-10-22 at 9 30 49 AM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jackyuan1-add-code-spell-checker-4101 gh-pages
git pull https://github.com/jackyuan1/website.git add-code-spell-checker-4101

@github-actions github-actions bot added good first issue Good for newcomers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Feature: Onboarding/Contributing.md size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Oct 22, 2023
@ajb176 ajb176 self-requested a review October 22, 2023 16:14
@kevin31yu kevin31yu self-requested a review October 22, 2023 17:02
Copy link
Member

@kevin31yu kevin31yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jackyuan1, everything looks great to me. I believe it is ready to merge. Lets wait for another reviewer before merging. Well done.

Copy link
Member

@kevin31yu kevin31yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jackyuan1, everything looks great to me. I believe it is ready to merge. Lets wait for another reviewer before merging. Well done.

Copy link
Member

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to me 🚀
small nitpick though: for future reference, "Add Code Spell Checker" seems like you added a spell checker to the codebase, would recommend being more specific like "Add Code Spell Checker Instructions to Documentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Onboarding/Contributing.md feature: spelling good first issue Good for newcomers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Code Spell Checker VS Code extension installation instructions

4 participants