added new variable github-handle to Eric Cho in 311-data.md#5768
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: EOD PM 10/23/23 |
|
Hack for LA Hacktorfest?? :D |
|
ETA: 10/26/23 |
KyleA99
left a comment
There was a problem hiding this comment.
Looks great @kevin31yu code is properly changed and I do not see any issues in your screenshots or when I open locally on docker. Nice work. Approved from me.
pdimaano
left a comment
There was a problem hiding this comment.
@kevin31yu Good job: The branches are correct and the issue is linked. The webpage is visually unchanged on my system on desktop, mobile and tablet. The correct file was updated with the appropriate information. Also, for future pull requests, note that the contribution wiki states that no screenshots are necessary if there are no visual changes to the website. You can simply remove the section and write "No visual changes to the website." Otherwise, well done!
blulady
left a comment
There was a problem hiding this comment.
This branch is coming from the correct branch and going into gh-pages. There is a linked issue, it is correct and addressed in the PR by adding line 10 _projects. The code looks clean, only one commit and only one file changed.
Good job!!
Fixes #5713
What changes did you make?
github-handleto Eric Cho and checked with Docker at localhost:4000/Why did you make the changes (we will use this info to test)?
githubandpicturewith new variablegithub-handleScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied