Added github-handle variable to Tin Wei Chung#6132
Added github-handle variable to Tin Wei Chung#6132kwangric merged 2 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
jphamtv
left a comment
There was a problem hiding this comment.
Hey @aidenjlee4321 , nice work on this issue. The PR is correctly done with the appropriate branch, and the issue is correctly linked. The summary for changes is clear, and the source code edit is clean.
When working on future issues, please make sure to include the issue number in the issue branch name. This helps in easily referencing and tracking related work. 2.7.b Working on an issue (2): Create a new branch where you will work on your issue
Thanks!
kwangric
left a comment
There was a problem hiding this comment.
Branches are set up correctly and the corresponding issue is linked. The requested change has been made and the PR includes a description of the change made and why it was made. Everything still looks good in Docker.
Great work!
Fixes #6106
What changes did you make?
Added a variable called github-handle under Tin Wei Chung's record within the associated file.
Why did you make the changes (we will use this info to test)?
"Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file."
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.