Skip to content

Added github-handle variable to Tin Wei Chung#6132

Merged
kwangric merged 2 commits intohackforla:gh-pagesfrom
aidenjlee4321:add-handle-Tin-Wei-Chung
Jan 19, 2024
Merged

Added github-handle variable to Tin Wei Chung#6132
kwangric merged 2 commits intohackforla:gh-pagesfrom
aidenjlee4321:add-handle-Tin-Wei-Chung

Conversation

@aidenjlee4321
Copy link
Contributor

@aidenjlee4321 aidenjlee4321 commented Jan 19, 2024

Fixes #6106

What changes did you make?
Added a variable called github-handle under Tin Wei Chung's record within the associated file.

Why did you make the changes (we will use this info to test)?
"Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file."

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aidenjlee4321-add-handle-Tin-Wei-Chung gh-pages
git pull https://github.com/aidenjlee4321/website.git add-handle-Tin-Wei-Chung

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aidenjlee4321/website/blob/add-handle-Tin-Wei-Chung/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 19, 2024
Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aidenjlee4321 , nice work on this issue. The PR is correctly done with the appropriate branch, and the issue is correctly linked. The summary for changes is clear, and the source code edit is clean.

When working on future issues, please make sure to include the issue number in the issue branch name. This helps in easily referencing and tracking related work. 2.7.b Working on an issue (2): Create a new branch where you will work on your issue

Thanks!

@kwangric kwangric self-requested a review January 19, 2024 14:47
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly and the corresponding issue is linked. The requested change has been made and the PR includes a description of the change made and why it was made. Everything still looks good in Docker.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Tin Wei Chung in civic-tech-jobs.md

3 participants