Modified hamburger-nav.html, hamburger-nav.js#6151
Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom Jan 28, 2024
Merged
Modified hamburger-nav.html, hamburger-nav.js#6151t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
bot
added
role: front end
Member
|
Review ETA: 10 PM 1/26/24 |
chelseyklein
approved these changes
Jan 27, 2024
Member
There was a problem hiding this comment.
Great work, @robertnjenga!
- The branch is correct and issue is linked
- I've reviewed the issue and tested in Firefox, Chrome, and Safari on MacOS using voiceover. The changes work great and follow the requirements specified in the issue. 🤩
Member
|
ETA: EoD 1/28/24 |
freaky4wrld
approved these changes
Jan 28, 2024
Member
freaky4wrld
left a comment
freaky4wrld
left a comment
There was a problem hiding this comment.
@robertnjenga thanks for taking up the issue, here are my observations:
- the to/from branch is correct
- the linked issue is correct as well
- the changes done are mentioned along with the reason to make those changes
- the testing info is also provided
- on testing the changes locally, the AT are able to access the
hamburger-menu-itemas required and specified - I have tested the changes in Safari and Chrome on MacOS....
PR approved!!!
This was referenced Aug 10, 2025
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4301
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)