Skip to content

Proj filter styling#619

Merged
cnk merged 20 commits intohackforla:gh-pagesfrom
ye-susan:proj-filter-styling
Jul 20, 2020
Merged

Proj filter styling#619
cnk merged 20 commits intohackforla:gh-pagesfrom
ye-susan:proj-filter-styling

Conversation

@ye-susan
Copy link
Contributor

@ye-susan ye-susan commented Jul 20, 2020

fixes #254
Edited styles for Project Filters, and adjusted 'Submit Your Pitch' button on mobile view

@ye-susan ye-susan requested a review from cnk July 20, 2020 01:56
@cnk
Copy link
Member

cnk commented Jul 20, 2020

Looks excellent. I found on UI issue. If you choose more than one item in a list - and then uncheck one of them, the pink highlight on the dropdown name goes away, even though there are items still checked.

Screen Shot 2020-07-19 at 7 17 12 PM

@ye-susan
Copy link
Contributor Author

I've added a counter to address the checkedbox bug, and have removed unused code (when I was still experimenting with the styling in javascript)

@cnk cnk merged commit dee78f8 into hackforla:gh-pages Jul 20, 2020
@ye-susan ye-susan deleted the proj-filter-styling branch July 20, 2020 17:58
@cnk cnk mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create project filtering on HFLA Home Page

3 participants