Skip to content

add github-handle to member Tan Zhou#6215

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
angela-lee1:add-new-variable-github-handle-tan-zhou-6192
Feb 4, 2024
Merged

add github-handle to member Tan Zhou#6215
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
angela-lee1:add-new-variable-github-handle-tan-zhou-6192

Conversation

@angela-lee1
Copy link
Member

@angela-lee1 angela-lee1 commented Feb 3, 2024

Fixes #6192

What changes did you make?

  • add GitHub-handle variable for member Tan Zhou
  • made chage in civic-opportunity-project.md

Why did you make the changes (we will use this info to test)?

  • creating a single variable github-handle to hold the GitHub handle for each member of the leadership team.
  • Eventually, github-handle will replace the GitHub and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

github-actions bot commented Feb 3, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b awlFCCamp-add-new-variable-github-handle-tan-zhou-6192 gh-pages
git pull https://github.com/awlFCCamp/website.git add-new-variable-github-handle-tan-zhou-6192

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/awlFCCamp/website/blob/add-new-variable-github-handle-tan-zhou-6192/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 3, 2024
@njackman-2344 njackman-2344 self-requested a review February 3, 2024 02:22
@elliot-d-kim elliot-d-kim self-requested a review February 3, 2024 02:23
@njackman-2344
Copy link
Member

@awlFCCamp The change in code looks good as I pulled it into docker.

I see in #6192, spaces instead of tab for .yml

Before I approve review, I see inconsistent comment style under visuals with 404 links. If no visual change, please comment underneath with no visual change under screenshots heading :). Thanks!

@angela-lee1
Copy link
Member Author

angela-lee1 commented Feb 3, 2024 via email

@angela-lee1
Copy link
Member Author

angela-lee1 commented Feb 3, 2024 via email

@elliot-d-kim
Copy link
Member

elliot-d-kim commented Feb 3, 2024

I accidentally posted my review as a comment so I deleted it. I see that you've responded to it (I guess it was still available in your email inbox) and I'll formally review the PR properly by the end of the day! Thanks for understanding.

Copy link
Member

@elliot-d-kim elliot-d-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @awlFCCamp, this is looking pretty good!

  • Branches and naming was done properly,
  • issue is linked, and
  • code looks clean and accurate!

The summary is in great shape after the adjustments you made: good detail and reasoning. Thanks for also cleaning up the screenshots section!

By the way, no need to keep any empty bullet points. Deleting them would make your PR cleaner -- just something to keep in mind moving forward.

Thanks again and nice work, I'm happy to approve this :)

Copy link
Member

@njackman-2344 njackman-2344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches and naming looks good and accurate
issue is linked
code great
Thank you for comment consistency with no screenshot changes at bottom
PR Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Tan Zhou in civic-opportunity-project.md

4 participants