Skip to content

Update Language Merging to Support Projects with Multiple Additional Repositories#6255

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
jphamtv:display-languages-multi-repos-5160
Feb 15, 2024
Merged

Update Language Merging to Support Projects with Multiple Additional Repositories#6255
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
jphamtv:display-languages-multi-repos-5160

Conversation

@jphamtv
Copy link
Member

@jphamtv jphamtv commented Feb 6, 2024

Fixes #5160

What changes did you make?

  • _projects/civic-tech-index.md:
    • Updated additional-repo-ids format to enable support for multiple additional repositories.
       
  • _layouts/project.html:
    • Applied Liquid's join filter to convert multiple additional repository IDs from a project's Markdown file into a comma-separated string.
       
  • assets/js/projects.js:
    • Modified JavaScript logic to enhance the merging of languages from multiple repos associated with a project.
       
  • assets/js/current-projects.js:
    • Updated JavaScript logic in the retrieveProjectDataFromCollection function to merge languages from multiple repos associated with a project more efficiently.
    • Refined code formatting within this function for better readability, maintainability, and consistency.

Why did you make the changes (we will use this info to test)?

  • These changes upgrade the existing language display feature to accommodate projects with more than two additional repository IDs in the Markdown file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

- Update additional-repo-ids format in civic-tech-index.md
- Add liquid filter for multi-repo support in project.html
- Merge languages across multiple repositories in project.js.
- Dynamically handle additional repo IDs in current-project.js.
@github-actions
Copy link

github-actions bot commented Feb 6, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jphamtv-display-languages-multi-repos-5160 gh-pages
git pull https://github.com/jphamtv/hackforla-website.git display-languages-multi-repos-5160

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jphamtv/website/blob/display-languages-multi-repos-5160/CONTRIBUTING.md  

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 3pt Can be done in 13-18 hours Complexity: Extra Large labels Feb 6, 2024
@t-will-gillis t-will-gillis self-requested a review February 11, 2024 17:18
@t-will-gillis
Copy link
Member

avail: 2/11
eta: 2/11

@t-will-gillis
Copy link
Member

New eta: 2/13

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jphamtv Fantastic work! I am able to confirm that "Civic Tech Index" in Docker matches the live site, and did not find any discrepancies when checking some of the other projects. The code edits appear to satisfy the other criteria (no additional-repo-ids, with the add'l repo but empty, with one add'l repo, and with multiple add'l repos. )

And great job picking up the minor edits (projectLanguageArr --> projectLanguageArray, semicolons, etc.)- thanks for tackling this issue!

@t-will-gillis t-will-gillis merged commit 0513eff into hackforla:gh-pages Feb 15, 2024
@jphamtv
Copy link
Member Author

jphamtv commented Feb 15, 2024

@t-will-gillis - thanks for the feedback and review!

@jphamtv jphamtv deleted the display-languages-multi-repos-5160 branch February 15, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Extra Large P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display languages for projects that have 2 or more repos

2 participants