Skip to content

Added github handle variable to markdown file#6305

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ramitaarora:add-new-variable-5879
Feb 19, 2024
Merged

Added github handle variable to markdown file#6305
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ramitaarora:add-new-variable-5879

Conversation

@ramitaarora
Copy link
Member

@ramitaarora ramitaarora commented Feb 16, 2024

Fixes #5879

What changes did you make?

  • I added the github handle variable to the civic tech jobs markdown file
  • I ensured that there were no changes visible on the project webpage.

Why did you make the changes (we will use this info to test)?

  • There needs to be a github handle variable for each member of the team, which will eventually replace the github and picture variables.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visible changes to website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ramitaarora-add-new-variable-5879 gh-pages
git pull https://github.com/ramitaarora/hfla-site.git add-new-variable-5879

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/ramitaarora/website/blob/add-new-variable-5879/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 16, 2024
@irais-valenzuela irais-valenzuela self-assigned this Feb 17, 2024
@irais-valenzuela
Copy link
Member

irais-valenzuela commented Feb 17, 2024

Review ETA: EOD 2/18/24
Availability: Sunday 10-11am

@robertnjenga robertnjenga self-requested a review February 17, 2024 21:15
@robertnjenga
Copy link
Member

Review ETA: 02/17/2024
Availability: 12pm - 4pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramitaarora, Thank you for taking up this issue.
The PR is done with the correct branch, you linked the issue, descriptions of what you did and why the changes were needed, and the correct code changes were made - adding a github-handle variable to the civic-tech-jobs.md file. Great job!

Copy link
Member

@irais-valenzuela irais-valenzuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramitaarora, changes look good! The branches are correct, issue number is linked, and you completed the assignment well. Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Jen Chung in civic-tech-jobs.md

4 participants