Skip to content

Add new variable "github-handle" to member Jenn Wu#6352

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
aconstas:add-github-handle-5881
Feb 23, 2024
Merged

Add new variable "github-handle" to member Jenn Wu#6352
jphamtv merged 1 commit intohackforla:gh-pagesfrom
aconstas:add-github-handle-5881

Conversation

@aconstas
Copy link
Member

@aconstas aconstas commented Feb 21, 2024

Fixes #5881

What changes did you make?

  • Add new variable github-handle for Jenn Wu (line 43)

Why did you make the changes (we will use this info to test)?

  • Per issue: "Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file."

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Added variable. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aconstas-add-github-handle-5881 gh-pages
git pull https://github.com/aconstas/website.git add-github-handle-5881

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aconstas/website/blob/add-github-handle-5881/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours Added to dev/pm agenda labels Feb 21, 2024
@W1LD-R W1LD-R self-requested a review February 21, 2024 21:26
@W1LD-R
Copy link
Member

W1LD-R commented Feb 21, 2024

Availability: Feb 21 & 22, 9AM to 7PM CST
Review ETA: Wed Feb 21 8PM CST

Copy link
Member

@W1LD-R W1LD-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aconstas! Great work on this :D

  • Your branch is set up correctly
  • You linked out to the issue from your PR properly
  • Your PR clearly states the changes you made and why
  • Github handle was added to civic-tech-jobs.md as instructed
  • I was able to reach Jenn Wu's GitHub page when I clicked the link in my browser via http://localhost:4000/
  • Works across mobile and desktop

Thanks again for working on this! Approved 👍

Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed no visible changes in developer mode on Chrome (desktop, iPad, and iPhone view), Firefox, and Safari browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Jenn Wu in civic-tech-jobs.md

4 participants