Add new variable "github-handle" to member Jenn Wu#6352
Add new variable "github-handle" to member Jenn Wu#6352jphamtv merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Availability: Feb 21 & 22, 9AM to 7PM CST |
W1LD-R
left a comment
There was a problem hiding this comment.
Hey @aconstas! Great work on this :D
- Your branch is set up correctly
- You linked out to the issue from your PR properly
- Your PR clearly states the changes you made and why
- Github handle was added to civic-tech-jobs.md as instructed
- I was able to reach Jenn Wu's GitHub page when I clicked the link in my browser via http://localhost:4000/
- Works across mobile and desktop
Thanks again for working on this! Approved 👍
heejung-hong
left a comment
There was a problem hiding this comment.
Good work!
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed no visible changes in developer mode on Chrome (desktop, iPad, and iPhone view), Firefox, and Safari browser.
Fixes #5881
What changes did you make?
github-handlefor Jenn Wu (line 43)Why did you make the changes (we will use this info to test)?
github-handlewill replace thegithubandpicturevariables, reducing redundancy in the project file."Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Added variable. No visual changes to the website.