Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
@duojet2ez Please complete the description of your work in the body of the PR. Thanks! |
|
@roslynwythe Does this look ok now? I filled in the description of what I did and put in a code block. Thanks!! |
|
Availability: 2/28 - 3/1 9AM-5PM CST |
|
Availability: weekdays afternoon/evening |
There was a problem hiding this comment.
Hey @duojet2ez, the Contributing doc also says to keep the final section about screenshots but to put the following instead of images:
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.
Can you add this as well? Otherwise your changes look good!
- You linked the issue correctly in your PR description
- Your branch is correct
- No visible changes, but everything still looks good across mobile and desktop on Chrome, Firefox, and Safari
Thanks for your work on this! 😄
aidanwsimmons
left a comment
There was a problem hiding this comment.
All looks good to me!
- issue linked correctly
- branch looks good
- changes made match the issue's action items
|
@gaylem done! |
There was a problem hiding this comment.
Hey @duojet2ez, thanks for making the updates the reviewers have requested. All the changes look good. PR approved.
Review dismissed as all feedback has been addressed and we have the necessary approvals for merging. Big thanks for your help and understanding!
Fixes #6044
What changes did you make?
In _includes/current-guides.html I replaced this line:
<h3><a href="{{item.resource-url}}" target="_blank">{{ item.title }}</a></h3>with this:
<h3><a href="{{item.resource-url}}" target="_blank" rel="noopener noreferrer">{{ item.title }}</a></h3>Why did you make the changes (we will use this info to test)?
To resolve the alert "Potentially unsafe external link" which appears in the CodeQL alert 3
Screenshots of Proposed Changes
No visual changes to website