Skip to content

update on issue 5878#6363

Merged
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
Shikha0428:update-github-handle-Sabrina-Heasley-5878
Feb 28, 2024
Merged

update on issue 5878#6363
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
Shikha0428:update-github-handle-Sabrina-Heasley-5878

Conversation

@Shikha0428
Copy link
Member

fixes #5878

What changes did you make?

  • Replace name: Sabrina Heasley with - name: Sabrina Heasley
    github-handle:

Why did you make the changes (we will use this info to test)?

  • We need to create a single variable github-handle to hold the github handle for each member of the leadership
    team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project
    file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Shikha0428-update-github-handle-Sabrina-Heasley-5878 gh-pages
git pull https://github.com/Shikha0428/website.git update-github-handle-Sabrina-Heasley-5878

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Shikha0428/website/blob/update-github-handle-Sabrina-Heasley-5878/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 23, 2024
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shikha0428 great job on this issue. The branches are formed correctly, the code change is clean and correct, you have described your work, and it checks out in the browser. Thank you!

@roslynwythe
Copy link
Member

Hi @kezzaam please let us know your availability and ETA to review this issue. Thanks!

@Shikha0428 Shikha0428 requested review from chelseyklein and removed request for chelseyklein and kezzaam February 28, 2024 02:16
@freaky4wrld freaky4wrld requested review from freaky4wrld and removed request for chelseyklein February 28, 2024 06:11
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shikha0428 thanks for taking the issue, the branches are good, issue linked is great, description provided is great as well. Docker testing is successful too.

Please check off the action items in the issue, thanks

PR approved!!

@freaky4wrld freaky4wrld merged commit 177e358 into hackforla:gh-pages Feb 28, 2024
@Shikha0428
Copy link
Member Author

@roslynwythe and @freaky4wrld Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Sabrina Heasley in civic-tech-jobs.md

3 participants